Problem/Motivation

Working on #3031379: Add a new test type to do real update testing I found this:

#2587063: Variable to config: search_active_modules [d7] adds two tests: Drupal\Tests\search\Unit\Plugin\migrate\source\d6\SearchPageTest and Drupal\Tests\search\Unit\Plugin\migrate\source\d7\SearchPageTest.

These tests inherit from Drupal\Tests\migrate\Kernel\MigrateSqlSourceTestBase (which is a kernel test base), but are placed in the unit test namespace.

Proposed resolution

Move these two tests to a kernel test namespace.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3055495_2.patch1.45 KBMile23
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Mile23 created an issue. See original summary.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Status: Active » Needs review
FileSize
3055495_2.patch1.45 KB

A patch.

See: #2587063-79: Variable to config: search_active_modules [d7] points 17 and 18.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude at ezCompany commented
Status: Needs review » Reviewed & tested by the community

Double checked and indeed MigrateSqlSourceTestBase extends KernelTestBase, so LGTM

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed ffd99ca739 to 8.8.x and 8dcec76bf1 to 8.7.x. Thanks!

  • alexpott committed ffd99ca on 8.8.x 
    Issue #3055495 by Mile23, Lendude: Search page migration tests are...

  • alexpott committed 8dcec76 on 8.7.x 
    Issue #3055495 by Mile23, Lendude: Search page migration tests are...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.