AuthenticationManager's role in setting the current user to anonymous is not clearly documented

Patch to change
"If no provider set an active user then the user is set to anonymous."
to
"If no provider set an active user then NULL is returned, which results in the user being set to anonymous."

I just tested this patch against 8.9.x-dev and I can verify that comment is changed to be more clearer and technically correct on file core/lib/Drupal/Core/Authentication/AuthenticationManager.php line 16.

Renamed the file to match naming convention.

Updated the comment to be more clearer.

Tested the new patch. Looks good to go in.

.

+++ b/core/lib/Drupal/Core/Authentication/AuthenticationManager.php
@@ -13,7 +13,8 @@
+ * If no provider set an active user, then NULL is returned. This results in the

Returned by what? I'm not sure this is better wording.

  public function onKernelRequestAuthenticate(GetResponseEvent $event) {
    if ($event->isMasterRequest()) {
      $request = $event->getRequest();
      if ($this->authenticationProvider->applies($request)) {
        $account = $this->authenticationProvider->authenticate($request);
        if ($account) {
          $this->accountProxy->setAccount($account);
          return;
        }
      }
    }
  }

No user is set to anonymous. It reality the active user remains the anonymous user.

Fix the documentation as suggested.

+++ b/core/lib/Drupal/Core/Authentication/AuthenticationManager.php
@@ -13,7 +13,7 @@
+ * If no provider set as an active user then the user remains anonymous.

The word "as" is not required.

Removed "as"

Looks good now, thanks.

Committed and pushed 7732e9d794 to 9.0.x and 46da1a6982 to 8.9.x and f2854ac58e to 8.8.x. Thanks!

Backported to 8.8.x as it is a docs fix.

diff --git a/core/lib/Drupal/Core/Authentication/AuthenticationManager.php b/core/lib/Drupal/Core/Authentication/AuthenticationManager.php
index 70c1c38655..d22a6c367c 100644
--- a/core/lib/Drupal/Core/Authentication/AuthenticationManager.php
+++ b/core/lib/Drupal/Core/Authentication/AuthenticationManager.php
@@ -13,7 +13,7 @@
  * provider detecting credentials for its method wins. No further provider will
  * get triggered.
  *
- * If no provider set an active user then the user remains anonymous.
+ * If no provider sets an active user then the user remains anonymous.
  */
 class AuthenticationManager implements AuthenticationProviderInterface, AuthenticationProviderFilterInterface, AuthenticationProviderChallengeInterface {
 

Updated for English grammar rules.