Description:
The module infobar provides a general purpose Drupal block which intends to show some information as a sticky notification on a webpage. The information is configurable in the block.

How its different from other modules:
Other modules which provides such functionality are more closely related to the cookie compliance. Infobar is a general purpose module.

Examples:
"Our websites privacy policy has been changed." "Ok"
"We have a scheduled maintenance on 25th July 2019 8pm to 9pm GMT" "Ok"
"We have a offer on this product" "Ok"

Project link

https://www.drupal.org/project/infobar

Git instructions

git clone --branch 8.x-1.x https://git.drupalcode.org/project/infobar.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-infobar.git

Comments

gopisathya created an issue. See original summary.

gopisathya’s picture

Issue summary: View changes
gopisathya’s picture

Issue summary: View changes
saesa’s picture

Issue summary: View changes
saesa’s picture

Issue summary: View changes
saesa’s picture

Status: Needs review » Needs work

In the infobar.info.yml this:

name: 'infobar'

should be:

name: 'Infobar'

In infobar.html.twig, you should change this for another description:

{#
/**
 * @file
 * Profile ws custom block.
 */
#}

And in the same file this line:

Since you have assigned a class you should not add the css online. Add it in the .css file.

<div class="infobar-wrapper" style="overflow: hidden;display: block;">

gopisathya’s picture

Status: Needs work » Needs review
avpaderno’s picture

Status: Needs review » Reviewed & tested by the community
  •   /**
       * {@inheritdoc}
       */
      public function defaultConfiguration() {
        return [] + parent::defaultConfiguration();
      }
    

    That code is not necessary. Just let Drupal call the parent method.

  • As descrived in Drupal core now using ES6 for JavaScript development, the ES6 file should be put in a .es6.js file, which is then transpiled to ES5.
avpaderno’s picture

Assigned: Unassigned » avpaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.