Problem/Motivation

The "Goutte\Client" class extends "Symfony\Component\BrowserKit\Client" that is deprecated since Symfony 4.3, use "\Symfony\Component\BrowserKit\AbstractBrowser" instead.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#6 3055197-6.drupal.patch1.98 KBmikelutz
#2 3055197-2.drupal.TEST_ONLY.patch197.95 KBmikelutz

Comments

mikelutz created an issue. See original summary.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Active » Needs review
StatusFileSize
new 3055197-2.drupal.TEST_ONLY.patch197.95 KB

Test patch

Status: Needs review » Needs work

The last submitted patch, 2: 3055197-2.drupal.TEST_ONLY.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Needs work » Postponed

So, the only test that fails is the test of the BrowserTestBase::getHttpClient() which mocks a Goutte Client. Testbot doesn't use it, as far as I know. Either way, I expect that by the time SF5 is ready, there will be a version of the Goutte client that doesn't trigger this deprecation, so I'm going to postpone this for right now

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Version: 8.9.x-dev » 9.0.x-dev
Status: Postponed » Needs review
StatusFileSize
new 3055197-6.drupal.patch1.98 KB

I believe we've updated our dependencies such that this error no longer exists. We can safely remove the skipped deprecation in Drupal 9.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Tests pass so we no longer need to skip this.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 93b73a5 and pushed to 9.0.x. Thanks!

  • alexpott committed 93b73a5 on 9.0.x 
    Issue #3055197 by mikelutz: [Symfony 5] The "Goutte\Client" class...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.