Problem

The NameFormatter has a dependency to the EntityTypeManager and that breaks any module that replaces that service. (webprofiler)

Solution

Use the correct interface in the constructor, namely the EntityTypeManagerInterface.

Tasks

Review

CommentFileSizeAuthor
#6 name-3055183-6-Dependency-Injection-Use-Interface.patch8.86 KBalan d.
#4 0001-Issue-3055183-Dependency-Injection-Use-Interfaces.patch11.56 KBsiegrist
#3 3055183-all-interfaces-replaced.patch6.07 KBsiegrist
#2 3055183-use-entity-manager-interface.patch1.46 KBsiegrist
replace-with-interface.patch1.44 KBsiegrist

Comments

Siegrist created an issue. See original summary.

siegrist’s picture

siegrist
Primary language German
commented
StatusFileSize
new 3055183-use-entity-manager-interface.patch1.46 KB

could not apply first patch...

siegrist’s picture

siegrist
Primary language German
commented
StatusFileSize
new 3055183-all-interfaces-replaced.patch6.07 KB

just found some more places!

siegrist’s picture

siegrist
Primary language German
commented
StatusFileSize
new 0001-Issue-3055183-Dependency-Injection-Use-Interfaces.patch11.56 KB

Redo

Status: Needs review » Needs work

The last submitted patch, 4: 0001-Issue-3055183-Dependency-Injection-Use-Interfaces.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

alan d.’s picture

alan d. commented
Status: Needs work » Needs review
StatusFileSize
new name-3055183-6-Dependency-Injection-Use-Interface.patch8.86 KB

Re-roll (well, fresh search and update was easier)

  • Alan D. committed da81d09 on 8.x-1.x 
    Issue #3055183 by Siegrist, Alan D.: Dependency Injection Use Interfaces
alan d.’s picture

alan d. commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

hussainweb’s picture

hussainweb
Primary language English
commented

Thanks for fixing this. I see there have been a lot of issues fixed since the last RC. Is there a schedule for the next RC release (or maybe even full release)?

Thank you for your work on this module.