I wonder could we make the theme more generic (now that we have layouts in Core) and therefore remove it from the demo_umami profile and add it as a supported Core theme? It’d be great to have a new theme for Drupal Core for Drupal 9 (we didn’t have one for D8 and I really don’t think Bartik is up to scratch anymore).

  • Basically, get all the layouts out of template files into config in Layout Builder.
  • Remove everything that is hard-coded in the theme and make sure these things are placed where they are by preprocess or some other mechanism (config, probably)
  • ensure the menu set up and all regions are just using generic markup, etc.
  • Not sure what we’d do about icons, but I’m sure with some thought we’d figure it out.

Let's realise this is a bad idea and close the issue or else feel there is some merit in it and start discussing it. Looking forward to your comments.

Comments

markconroy created an issue. See original summary.

shaal’s picture

shaal
he/him
Primary language English
Location Boca Raton, FL
commented
Related issues: +#2759849: Create a new user-facing core theme as part of a Drupal demo

I love this idea!

smaz’s picture

smaz
Primary language English
Location England, UK
commented

I'd be very up for this!

My only concerns is that in doing so, are that we don't:

  • Slow down progress on Umami due to the theme being a core theme / has to work with everything
  • Take too much focus away from the OOTB initiative/demo
  • Give ourselves more work than we're able to handle/cope with

Perhaps we'd still need to do a subtheme for the demo to do any demo-specific theming such as the icons, favicons, logo, preprocessing etc.

Version: 9.x-dev » 9.0.x-dev

The 9.0.x branch will open for development soon, and the placeholder 9.x branch should no longer be used. Only issues that require a new major version should be filed against 9.0.x (for example, removing deprecated code or updating dependency major versions). New developments and disruptive changes that are allowed in a minor version should be filed against 8.9.x, and significant new features will be moved to 9.1.x at committer discretion. For more information see the Allowed changes during the Drupal 8 and 9 release cycles and the Drupal 9.0.0 release plan.

xjm’s picture

xjm
she/her
Primary language English
commented
Version: 9.0.x-dev » 9.1.x-dev
Issue tags: +Needs subsystem maintainer review, +Needs product manager review

Interesting idea. There are definitely pros and cons to this. Part of the intent of Umami is to be able to theme for a specific usecase, in a way that a generic core theme can't.

Tagging for feedback from the other Umami maintainers as well as product managers. Thanks!

xjm’s picture

xjm
she/her
Primary language English
commented

Another downside is that Umami would then no longer be able to evolve in patch releases, since we'd have to worry about disruption if it were available generically in core.

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented

@xjm: yeah. The most important con mentioned here. Thanks for pointing out. While I absolutely advocate for the main motivation on which this issue/task/idea is based on. +1 for the idea and the issue created tho.

Maybe we can kindof "fork" that? It seems that the theme evolved to a certain attrackting level enough, so that it gets considered for such task here and we maybe can go from here in 2 different directions? One for core and the other for the ongoing efforts in the OOTB?

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Status: Active » Closed (won't fix)

Things have changed since this issue was opened and we now have, #3523324: Deprecate and remove the Umami demonstration profile from core, make it a contributed site template.

Therefor I am closing this feature request.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.