Closed (fixed)
Project:
DvG StUF-BG
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
15 May 2019 at 08:38 UTC
Updated:
12 Jun 2019 at 15:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
joshahubbers commentedThis patch can be applied AFTER the patch in #3053594: Add correspondentieAdres and verblijfsOfCorrespondentieadres tokens is applied.
The prefill is only changed for "vestiging" because the "persoon" prefill is already widely used, and we don't dare to change that without consulting users.
Comment #3
ralphvdhoudt commentedComment #4
ralphvdhoudt commentedCreated a patch with single line tokens and refactored the tokens to have subgroups for verblijfsadres, correspondentieAdres
Comment #5
ralphvdhoudt commentedComment #6
tvoesenek commentedPatch #4 looks good, the grouping gives makes selecting the right token easier. But if you now select one of these parent tokens:
No data is rendered and you get the following notice:
Comment #7
ralphvdhoudt commentedOnly works after applying https://www.drupal.org/files/issues/2019-05-22/add-sub.correspondentieAd...
These tokens fallback to the naamAdresWoonplaats token
Also made some changes to the tokens because the wrong ones were used
Ans made some changes to _dvg_stuf_bg_tokens_webform_address, to use the correct fields
Comment #8
ralphvdhoudt commentedComment #9
paulvandenburg commentedI've found some code standard/typo issues.
Typo in verblijfsadres
Please add a more descriptive comment.
Similar comment
Don't specify an optional parameter equal to the default value.
Same here
Typo, should be separator
Comment #10
ralphvdhoudt commentedResolved feedback #9
Comment #11
paulvandenburg commentedLooks good.
However I did get a few notices, which are not really related to this issue perhaps but fixing them here is faster than opening a new ticket.
See attached.
Comment #12
tvoesenek commentedReroll of #11 against the latest dev. The fixed notices also look good to me.
Comment #14
paulvandenburg commented