Closed (fixed)
Project:
Drupal core
Version:
11.x-dev
Component:
meetings
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
14 May 2019 at 17:13 UTC
Updated:
28 Nov 2024 at 16:09 UTC
Jump to comment: Most recent
Agenda:
Previous agenda: #3051782: [Layout Initiative meeting] 2019/5/14
| timplunkett (he/him) | Hi, Tim from Philadelphia |
| dyannenova | Hi, Iām Emilie in Portland, OR |
| shaal | Hi, Ofer Shaal, Florida |
| tedbow | Hello, Ted form Ithaca, NY |
| Alona Oneill | Hello. Iām Alona from San Francisco, CA |
| joshuabud | I'm Joshua in Spartanburg, SC |
| digantdj | Hi, I'm Digant from San Diego, CA |
| philalonso | Iām Phil in Phoenix, AZ |
| thalles | I'm Thalles in Belo Horizonte-MG, BR |
| johnwebdev | John from Sweden |
| mark_fullmer (he/him) | Mark from Tucson, Arizona |
| webchick | Angie from Vancouver, BC |
| damienmckenna | Damien from Bangor, ME, USA. |
| timplunkett (he/him) | #2924058: Discuss using Layout Builder to control full site layout and replace Block UI |
| timplunkett (he/him) | Doing this in core could be very tricky, because we'd need to land it with a migration path from Block UI |
| timplunkett (he/him) | It might be a lot more straightforward to do it from contrib, and indicate that you'd need to start from scratch with it (as part of an MVP) |
| tedbow | would have to do migration or could this something new sites could have and/or site opt into? |
| tedbow | Not that I donāt think contrib is not a good place to do it |
| timplunkett (he/him) | If it were in core, it'd be easy to switch Umami to it. I'm just worried about existing sites |
| tedbow | yep. but possilbly could opt in like LB does now(though this would be for whole site) |
| timplunkett (he/him) | right now we can cleanly copy over their Manage Display config to LB, because it's all one column |
| tedbow | sorry to side track. can be determined later. probably better to start in contrib anyways. just thinking of eventual core inclusion which we donāt need to worry about now |
| mark_fullmer (he/him) | Just to consider options, would ājustā doing a UI makeover of the Block UI that is Layout Builder-esque, be an option, without providing a unified API? |
| mikelutz (he/him) | The actual migration is probably doable, but I worry more about sites that donāt currently use LB being forced to. Ā I know currently my custom themes donāt play well with LB (Iām working on them), and I donāt want to be forced into LB before Iām ready. |
| timplunkett (he/him) | afaik we'd probably need a completely separate page.twig.html anyway, so yeah it'd be a big switch |
| timplunkett (he/him) | similar to how Panels Everywhere needed its own stuff at the theme layer |
| thalles | And a submodule of LB? |
| timplunkett (he/him) | haven't thought that far out @thalles, but probably. though core doesn't do submodules, it'd be alongside it in the /core/modules dir |
| timplunkett (he/him) | So far this has been a good meta/strategic discussion. I'm going to start another thread (3ļøā£) to discuss how we'd expect it to work from the editors perspective |
| thalles | I think this would be a middle ground |
| damienmckenna | There's also the question of how it would be handled - would LB_Anywhere just use the content section or would it take over the block region rendering? |
| tedbow | I think the idea is you wonāt have theme regions. |
| tedbow | but maybe the theme could provide default sections? |
| tedbow | to use in the layout everywhere? |
| kevincrafts | If a theme is already providing regions, I would just like to use layout builder within those regions |
| kevincrafts | as those regions should contain sections |
| damienmckenna | And that's why I asked the question - there's a difference of opinion between how different people view this, and I think the back-end developers should defer to the front-end developers in this regards. |
| timplunkett (he/him) | https://www.drupal.org/project/layout_builder_st https://www.drupal.org/project/layout_builder_at |
| tedbow | layout_builder_st is a port of #2946333: Allow synced Layout override Translations: translating labels and inline blocks which hopefully will be in core 8.8.0 |
| tedbow | Right now I donāt think you can have both enabled. or at least they wonāt work |
| timplunkett (he/him) | What expectations do people have for this? |
| dyannenova | Iāve been leaning towards an interface where a site editor can edit the global layout content from the same interface as the content layout, instead of a separate page. |
| dyannenova | Is that something that sounds useful? It gives the editor a more intuitive way to edit the site layout everywhere, but means we would need a way to illustrate which regions are global vs which are content. |
| tedbow | so then there would always be 1-to-1 relationship with lb content to lb fullsite? |
| tedbow | I guess the question is is there only 1 full-site setting like block UI or variations like Page Manager? |
| dyannenova | Variations would be interesting, I havenāt heard anyone ask for that as an mvp, but it could be a really useful feature further on |
| tedbow | ok give there is only for at first. editing in the same UI sounds great. buy also maybe where you could edit with a content setting. Ā For instance it would be in effect for Views pages also |
| tedbow | So even if āinterface where a site editor can edit the global layout content from the same interface as the content layout, instead of a separate page.ā would there also be separate page for instance if you havenāt enabled layout builder for a content type but still want to use it for the site-chrome? |
| damienmckenna | @dyannenova: is the intention that LB_Anywhere :wink: would control what goes in the theme's regions, or would it introduce another layer on top of that with its own layouts that ultimately go into the page's content area (ala panels_anywhere)? Or is this question redundant/outdated in D8? |
| dyannenova | @tedbow Thatās a good point. It would be useful for sites that arenāt using LB for content too. |
| dyannenova | @damienmckenna the idea so far is that it would replace theme regions with a layout builder-esque interface that builds the site layout with sections. |
| damienmckenna | @dyannenova: I would suggest discussing this with some additional theme maintainers to see how best to bridge the gap and ensure that existing functionality wouldn't get lost along the way. |
| kevincrafts | I would certainly need rule type variations, or if possible a cascading set of chrome layouts that could be applied to a particular node. For instance, adding in a list of articles in the sidebar of the page of all article nodes, and adding additional content in the sidebar for articles tagged with a particular term. |
| damienmckenna | At the very least there would need to be visibility rules to control it, or allow a way for something akin to Block Visibility Groups. |
| damienmckenna | And would lb_everywhere configurations be tied to a theme, so if you used a system to swap themes e.g according to different path, would the layout persist across the different themes, or would you need a different layout per theme? |
| damienmckenna | (for the last question, it seems like it would be tied per theme based upon comments above)Ā (edited) |
| timplunkett (he/him) | Right now the page.html.twig is primarily concerned with printing out the theme regions |
| timplunkett (he/him) | which is why placed blocks are tied to a theme, because of the regions |
| timplunkett (he/him) | in theory, if we do it right there's no need to tie this to themes |
| mark_fullmer (he/him) | Is there an existing issue that would be appropriate for making suggestions to the Layout Builder drag-and-drop UX? Our team was identifying some research-based best practices for a drag-and-drop interface, including a drop shadow on the moving object, a grab/grabbing cursor, and outlined blocks even when not in motion. |
| timplunkett (he/him) | I don't think there's an issue for that, unless @dyannenova knows of one off-hand |
| dyannenova | There isnāt an issue open for that right now. It would be great to have one. |
Participants:
timplunkett (he/him), dyannenova, shaal, tedbow, Alona Oneill, joshuabud, digantdj, philalonso, thalles, johnwebdev, mark_fullmer (he/him), webchick, damienmckenna, mikelutz (he/him), kevincrafts
Comments
Comment #2
tim.plunkettComment #3
tim.plunkettComment #4
tim.plunkettComment #5
tedbowComment #6
alonaoneill commentedComment #14
quietone commentedComment #18
quietone commentedComment #24
smustgrave commented