H5PReport throw an exception generation the report for fill-in answer [#3054422]

If I try to generate an H5PReport sometime I get an exception:
TypeError: Argument 1 passed to Drupal\opigno_h5p\TypeProcessors\FillInProcessor::processCRPs() must be of the type array, null given
The exception occurs viewing an answer that use an H5P Documentation Tool with a H5P Text input field (https://github.com/h5p/h5p-text-input-field) element inside.
This widget is defined with interactionType: fill-in but the FillInProcessor that generate the report doesn’t expect a response without a CRP and this widget doesn’t have this patterns.
This processor works fine with the Fill in blanks element https://github.com/h5p/h5p-blanks (this one also is defined as fill-in).

Comment	File	Size	Author
#7	opigno_module-fill_in_processor_report-3054422-7.patch	2.33 KB	peximo
#6	opigno_module-fill_in_processor_report-3054422-6.patch	2.29 KB	peximo
#4	opigno_module-fill_in_processor_report-3054422-4.patch	2.27 KB	peximo

Comments

Comment #1

13 May 2019 at 15:11

peximo created an issue. See original summary.

Comment #2

peximo commented 13 May 2019 at 15:12

Issue summary:

View changes

Comment #3

peximo commented 13 May 2019 at 15:12

Issue summary:

View changes

Comment #4

peximo commented 13 May 2019 at 15:25

Status	File	Size
new	opigno_module-fill_in_processor_report-3054422-4.patch	2.27 KB

This patch adds a simple question/response report when CRPs are not available.

Comment #5

catch

he/him

English

commented 14 May 2019 at 15:50

Status:

Active

» Needs work

+++ b/ActivityTypes/opigno_h5p/src/TypeProcessors/FillInProcessor.php
@@ -36,23 +38,42 @@ class FillInProcessor extends TypeProcessor {
+        $description .

Does this need to be escaped?