Working on #3031379: Add a new test type to do real update testing I came across this.
If your test has no test methods, then DeprecationListenerTrait::registerErrorHandler() can't reflect on the results object to add another listener (because there is not a results object). This means your test result is always THE ERROR HANDLER HAS CHANGED!
This is obviously mitigated by the fact that you should have test methods in your test class, but we can add some DX happiness through defensive coding.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 3052625_3.patch | 1.47 KB | mile23 |
Comments
Comment #2
mile23Comment #3
mile23Comment #4
mile23Comment #5
alexpottFair enough. I manually tested this by removing all the tests from a unit test and saw it error as described in the issue summary. With the patch attached you still get the THE ERROR HANDLER HAS CHANGED! notice but you don't get a stack trace so this looks good to go. There's not much we can do about the notice and it's not important anyway because there are no tests which is an error anyways.
Comment #6
mile23Yah the use case for this is when you change test method names to
te_stSomething()for debugging, and then you get the handler changed error. :-)Comment #9
gábor hojtsyThanks, committed.