In SimplesamlSubscriber:

  • \Drupal::routeMatch() should be injected into constructor of SimplesamlSubscriber.
  • \Drupal::currentUser()->isAnonymous() can be replaced with $this->account->isAnonymous().

In SimplesamlExternalauthSubscriber:

  • \Drupal::moduleHandler() should be injected into the constructor
CommentFileSizeAuthor
#3 simplesamlphp_auth-dependency-injection-in-event-subscribers-3052343-3.patch6.34 KBoknate

Comments

oknate created an issue. See original summary.

oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes
oknate’s picture

oknate
Location Greater New York City Area
commented
Status: Active » Needs review
StatusFileSize
new simplesamlphp_auth-dependency-injection-in-event-subscribers-3052343-3.patch6.34 KB
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Thanks.

  • Berdir committed 3c680ed on 8.x-3.x authored by oknate 
    Issue #3052343 by oknate: Fix dependency injection in event subscribers

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

idebr’s picture

idebr commented 
+++ b/src/EventSubscriber/SimplesamlSubscriber.php
@@ -119,7 +130,7 @@ class SimplesamlSubscriber implements EventSubscriberInterface {
+    if ($this->account->isAnonymous() && $this->routeMatcht->getRouteName() == 'user.login') {

Typo here: $this->routeMatcht

Fix is available at #3064139: Typo causing issue with direct IDP login

oknate’s picture

oknate
Location Greater New York City Area
commented

D'oh. That's my error. Sorry about that.