It would be nice if the external library would be installed automatically when the module is installed with composer, so you don't have to include it in your project composer.

Solving #3035827: Remove deprecated calls to Libraries also.

CommentFileSizeAuthor
#5 add-composer-3052091-5.patch5.06 KBjoshahubbers
#2 add-composer-3052091-2.patch1.13 KBjoshahubbers

Comments

JoshaHubbers created an issue. See original summary.

joshahubbers’s picture

joshahubbers commented
StatusFileSize
new add-composer-3052091-2.patch1.13 KB

Added composer.json to the module.

  • JoshaHubbers committed 5a9db35 on 8.x-1.x 
    Issue #3052091 by JoshaHubbers: Add external library with composer

  • JoshaHubbers committed 856cb78 on 8.x-1.x 
    Issue #3052091 by JoshaHubbers: Add external library with composer
joshahubbers’s picture

joshahubbers commented
Issue summary: View changes
StatusFileSize
new add-composer-3052091-5.patch5.06 KB

Working on this issue, I discovered that Symphony has a IBAN validator natively. So the external library is not needed at all.
This patch removes the library, and also removes the denpendency on libraries module.

  • JoshaHubbers committed ae01933 on 8.x-1.x 
    Issue #3052091 by JoshaHubbers: Add external library with composer
joshahubbers’s picture

joshahubbers commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.