Comments

MustangGB created an issue. See original summary.

mustanggb’s picture

Status: Active » Needs review
StatusFileSize
new677 bytes

And a patch.

mustanggb’s picture

Issue tags: +Drupal 7.69 target
mustanggb’s picture

Issue tags: -Drupal 7.69 target +Drupal 7.70 target
izmeez’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -Drupal 7.70 target +Drupal 7.72 target

The patch in #2 applies without difficulty to Drupal 7.71 and it is a backport of the patch committed to D8 and identical to it.

joseph.olstad’s picture

Issue tags: -Drupal 7.72 target +Drupal 7.74 target

D8 already has this.

mustanggb’s picture

mcdruid’s picture

Issue tags: -Drupal 7.76 target

I doubt that there's test coverage for this in D7, but checking for a "green board" anyway.

The D8 change had a CR. If we commit this, we should probably also have a CR which can just reference https://www.drupal.org/node/1451282

fabianx’s picture

Approved, given it was committed 9 years ago and even then no one knew, this should be safe. But needs a CR.

mcdruid credited nod_.

mcdruid credited sun.

mcdruid credited xjm.

mcdruid’s picture

Status: Reviewed & tested by the community » Fixed

Committed and added a very minimal CR referencing the one we're backporting.

Thanks all!

mustanggb’s picture

Cheers.

mustanggb’s picture

Not sure why there is no commit reference in this issue, but here is a link to the actual commit:
https://git.drupalcode.org/project/drupal/-/commit/dfc3a42d2b979ff84099d...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.