Meeting will happen in #d9readiness on drupal.slack.com.

Hello and welcome to this Drupal 9 readiness meeting!

This meeting:
➤ Is for core and contributed project developers as well as people who have integrations and services related to core. Site developers who want to stay in the know to keep up-to-date for the easiest Drupal 9 upgrade of their sites are also welcome.
➤ Usually happens every other Monday at 19:00 UTC.
➤ Is done over chat.
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to: `https://www.drupal.org/project/drupal/issues/3051450`
➤*Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

Moderated By: Alex Pott

1️⃣ If you’re here please introduce yourself and say hi :slightly_smiling_face:

mglaman Matt here, drupal-check person
alexpott Alex here, Drupal core person
Nikunj Kotecha Nik here, few contrib modules maintainer
safetypin hi there, i’m yet another matt.
mikelutz Mike here, got caught in in work catchup today, and this slipped my schedule. Hi!
Shawn Duncan Hi :wave::skin-tone-2: I have a couple contrib modules and really want Drupal to shine in the 8->9 transition.
Gábor Hojtsy (he/him) Gábor, another core person -- joining late

2️⃣ Please suggest any topics for discussion in this thread - I’ll then turn them in to a thread for discussion

Matt Glaman I have no topics :slightly_smiling_face: Unless there was a generic `drupal-check feedback` one, but I have issues that were opened from DrupalCon contributors. 'm assuming it's going to be a light day today

3️⃣ https://www.drupal.org/project/drupal/issues/3047294 came out of discussions with Symfony project

alexpott The other related issue https://www.drupal.org/project/drupal/issues/3039047 might off us a nice path to - standardising on PSR-18 client implementation.
mglaman Interesting... What kind of impact would this have for Commerce? Just about everything uses Guzzle
johndevman i noticed the "more performant" for the benefits, any more specifics on that? :slightly_smiling_face:
alexpott Yeah well I’d imagine we’d maintain the current client but deprecate it and add a new service. To make it easier.
johndevman one more thing. "This Component is experimental. Experimental features are not covered by Symfony's Backward Compatibility Promise." is it too early?
alexpott It will be part of 4.3 and has little depedencies so it is technically possible. There’s some fun about minimum PHP versions. But also a way forward might be to add a PSR-18 client and use the guzzle bridge and then swap to Symfony under the hood in D9.
alexpott @johndevman re perfromance I saw some tweet comparing server loads after swapping from the httplug client - unfortunately can’t dig that tweet out atm
johndevman does guzzle have a psr-18 bridge though? couldn't find it
alexpott Hmmm I thought it did. Well there is https://github.com/ricardofiorani/guzzle-psr18-adapter but we’d need something with an official roadmap / security etc. There’s 3 in https://packagist.org/?query=psr18 :slightly_smiling_face:
johndevman :thumbsup:
Gábor Hojtsy (he/him) @alexpott they wanted to meet me last week but the timing did not work out. I think we should get framework managers on the call for this. I am not even the right person for that discussion :) It was "Michael from Symfony".

4️⃣ In a major win https://www.drupal.org/project/coder/issues/2908391 has landed in coder - so now we need to update coder for core and apply the rule and fix it everywhere

Nikunj Kotecha is this going to be added by default in BLT?
alexpott BLT is an Acquia thing right?
Nikunj Kotecha yes #blt
alexpott So if that uses coder and uses core’s configuration or the Drupal standard then yep I guess it would be. I don’t know how BLT handles coding standards though so I can’t say anything for sure.
Nikunj Kotecha ok, I'll check and if required update coder module
Gábor Hojtsy (he/him) @alexpott do we need an issue to update coder in core first? How is the process? If we have a update coder patch that would now fail badly :) do we fix the fails in that same patch?
Gábor Hojtsy (he/him) Also a release manager question, do we do this in rc? Or should we do this in 8.8 only at this point? @catch
catch @Gábor Hojtsy (he/him) probably 8.8.x only but +1 to doing that asap.
Gábor Hojtsy (he/him) All right. Makes sense.
Gábor Hojtsy (he/him) I see the coder update was committed now. So that applies to new patches. How do we prove in fixed patches that we decreased the number of fails? Do we need to prove that other than not increasing it? I have not been through a coding standard update like this before so learning the ropes here. It looks like it would start with https://www.drupal.org/project/drupal/issues/3048244#comment-13070162 Although dubiously it did not fail with that either...
alexpott @Gábor Hojtsy (he/him) so now we need to file issues that turn on each rule and fix the fails - just updating the packages does not add the rules to core\/phpcs.xml.dist - so nothing dubious going on.
Gábor Hojtsy (he/him) It seemed like the passing patch you commented should.not have a rule. :) But having the rule should fail :) anyway I am not yet at my computer before tomorrow so should look then and not judge from my phone
alexpott Ah I see - yeah we’ve not turned on the “fail the test suite” if phpcs fails option yet. For many reasons. The patch which added the rules did fail a phpcs run v badly :slightly_smiling_face: but DrupalCI doesn’t surface that for core yet.
Gábor Hojtsy (he/him) Ah! Ok so how do we break these up? Last I tried I spent 2-3h on a patch came to 100k file and probably did not fix too much of all. So any single patch would fail parts of it.
alexpott So the accepted way is to add an issue that enables a rule and then fix all the things in that issue. Because we can run the phpcs manually we can get to a done state.
Gábor Hojtsy (he/him) Hm even if a 500k patch which would in no small part be manual?
alexpott Yes unless you want to split it up into bits that can be tested via a custom phpcs command to run against each bit. But in the past we’ve done these things in one because it gets it done rather than half done. So sometimes we’ve had mulitple issues and then combined them together at the last moment
lendude Splitting it up somehow would also allow more people to work on it at the same time with much less risk of doing double work
alexpott yep - and that does not preclude us from joining it together at the end
Gábor Hojtsy (he/him) Ok. This helps a lot.

5️⃣ Themes and D9 - we had a good meeting in Seattle about Frontend deprecation - https://www.drupal.org/project/drupal/issues/2659890

alexpott One super interesting action coming out of that meeting is that in Drupal 9 we want to introduce a starter theme rather than base themes.
alexpott And another idea was to create components that are markup / CSS / JavaScript and can only be overridden as a whole rather than the current state where you can override CSS or JS or markup or any combination.
alexpott @lauriii will be filing some new issues about all of this soon - or probably has done already!
lauriii I’ll be doing work on this later this week :slightly_smiling_face: Just got back home earlier today.
safetypin i think the basic theme is a really great starting point if a decision hasn’t been made.
alexpott @safetypin yeah the basic theme is an inspiration!
Gábor Hojtsy (he/him) What is the difference between a starter and base theme? Starter is supposed to be copy pasted not inherited from / extended? Also I see that link does not reflect the discussion yet(?)

Comments

Gábor Hojtsy created an issue. See original summary.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue summary: View changes
alonaoneill’s picture

alonaoneill commented

Gábor Hojtsy credited Lendude.

Gábor Hojtsy credited alexpott.

Gábor Hojtsy credited catch.

Gábor Hojtsy credited johndevman.

Gábor Hojtsy credited lauriii.

Gábor Hojtsy credited mglaman.

Gábor Hojtsy credited mikelutz.

Gábor Hojtsy credited mlhess.

Gábor Hojtsy credited nikunjkotecha.

Gábor Hojtsy credited safetypin.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue summary: View changes
Status: Active » Fixed

Pieced together the log thanks to dump from @mlhess. Unfortunately @alexpott did not use the meeting template so the script did not recognize the meeting in the log which meant there was extensive manual work involved in reconstructing threads for this.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Version: 9.x-dev » 9.0.x-dev

The 9.0.x branch will open for development soon, and the placeholder 9.x branch should no longer be used. Only issues that require a new major version should be filed against 9.0.x (for example, removing deprecated code or updating dependency major versions). New developments and disruptive changes that are allowed in a minor version should be filed against 8.9.x, and significant new features will be moved to 9.1.x at committer discretion. For more information see the Allowed changes during the Drupal 8 and 9 release cycles and the Drupal 9.0.0 release plan.