Closed (fixed)
Project:
Drupal core
Version:
8.8.x-dev
Component:
migration system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
27 Apr 2019 at 03:09 UTC
Updated:
7 Aug 2019 at 09:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
quietone commentedRemove the test.
Comment #3
mikelutzThis is a test, unused by contrib. No need to keep it around http://grep.xnddx.ru/search?text=MigrateUpgradeTestBase
Comment #4
xjmNormally we treat test base classes as API. However:
So in this case I'm comfortable removing this. Also nice to get rid of it since it's a WTB test and all.
I do think we should add a small change record for the removal though, on the off chance that someone out there does depend on this somehow, since it is technically a BC break. It should be committed to 8.8.x only.
I think @catch agrees on removing it since he pinged me asking but he didn't explicitly say he was +1 also, so I or he can get confirmation of that before commit.
Comment #5
quietone commentedAdded a very brief change record.
Comment #6
mikelutzBack to rtbc. Despite the +1 from @xjm, I'm tagging for RM review just to make sure @catch has a chance to voice any objections per #4 and @catch and @xjm can coordinate the commit.
Comment #7
catchYes just to confirm I am indeed +1 it's just good with borderline things to get a second opinion so we're as consistent as possible.
Committed 1fd92fc and pushed to 8.8.x. Thanks!
Comment #9
catch