This module provide a entity tab to view in front in case of drupal headless.
It takes the path or the alias path of the entity to build the uri.

Project link

https://www.drupal.org/project/redirect_2_front

Git instructions

git clone --branch 8.x-1.x https://git.drupalcode.org/project/redirect_2_front.git

Comments

Musa.thomas created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
Status: Active » Needs review

Thank you for your contribution! Reviewers will check the project and report here what should be changed.

altagrade’s picture

altagrade commented

Please fix the following errors found with the Coder module:

phpcs --standard=Drupal redirect_2_front

FILE: /var/www/docroot/modules/redirect_2_front/redirect_2_front.module
-----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------
  1 | ERROR | [x] Missing file doc comment
 13 | ERROR | [x] Expected 1 blank line after function; 0 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------


FILE: /var/www/docroot/modules/redirect_2_front/redirect_2_front.routing.yml
----------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------
 9 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------


FILE: /var/www/docroot/modules/redirect_2_front/redirect_2_front.info.yml
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-----------------------------------------------------------------------------------------------------------


FILE: /var/www/docroot/modules/redirect_2_front/redirect_2_front.links.task.yml
-------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------
 10 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------


FILE: /var/www/docroot/modules/redirect_2_front/src/Form/SettingsForm.php
-------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------
 103 | WARNING | Possible useless method overriding detected
-------------------------------------------------------------------------


FILE: /var/www/docroot/modules/redirect_2_front/src/Controller/Front.php
------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------
 86 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------


FILE: /var/www/docroot/modules/redirect_2_front/src/EntityTypeInfo.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 30 | ERROR | Parameter $config_factory is not described in comment
----------------------------------------------------------------------
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work

To the reviewers: Please remember to change status, when reporting what need to be changed in the module/theme.

musa.thomas’s picture

musa.thomas
Primary language French
Location France 🇫🇷
commented
Status: Needs work » Needs review

thanks for the review, all has been fixed, commit and push into dev branch

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Reviewed & tested by the community

Thanks for your contribution!

Review:
* redirect_2_front_entity_type_alter(): why do you need this hook? Please add a code comment. Same for redirect_2_front_entity_operation().
* config schema is missing, see https://www.drupal.org/docs/8/api/configuration-api/configuration-schema...

Otherwise looks good to me, I don't see any security issues.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.