The installation instructions require you to copy just the lozad.min.js file and place it into /libraries/lozad, however the actual lozad distribution package places the minified js file under /dist.

Normally this wouldn't be a problem because you can manually move that file to the expected location, but if you're managing your Drupal site with Composer and installing js libraries via Asset Packagist, you don't really get to control where the files end up. Because of this, I think it would be better for the module to look for the minified js at the path defined by the lozad package.

Comments

amklose created an issue. See original summary.

amklose’s picture

Status: Active » Needs review
StatusFileSize
new1.46 KB

Here's a patch I made that allows me to just require the lozad library with Composer. I edited the libraries file which actually points to the minified js, the install file which is checking to see if the js exists before installing the module, and the README file to slightly modify the installation instructions.

psebborn’s picture

Assigned: Unassigned » psebborn

  • psebborn committed 01e499a on 8.x-1.x authored by amklose
    Issue #3050772 by amklose: Module is looking for lozad in the wrong...
psebborn’s picture

Thanks for this, good spot! I've added this now, will be in the next release

psebborn’s picture

Status: Needs review » Fixed
psebborn’s picture

Assigned: psebborn » Unassigned
psebborn’s picture

Status: Fixed » Closed (fixed)