In Drupal8 menu links are defined in static .yml files see the CR https://www.drupal.org/docs/8/creating-custom-modules/add-a-menu-link

CommentFileSizeAuthor
#5 screenshot-menu-2019.04.26-14-50-13.jpg52.93 KBsatyanarayan reddy
#5 add-menu-link-of-the-module-settings-page-3050418-4.patch888 bytessatyanarayan reddy
#3 with_patch_hypothesis.png153.78 KBkrina.addweb
#2 add-menu-link-of-the-module-settings-page-3050418-2.patch354 bytesamarphule

Comments

amarphule created an issue. See original summary.

amarphule’s picture

amarphule commented
Assigned: amarphule » Unassigned
Status: Needs work » Needs review
StatusFileSize
new add-menu-link-of-the-module-settings-page-3050418-2.patch354 bytes

Created a menu link of the module setting page ap per CR https://www.drupal.org/docs/8/creating-custom-modules/add-a-menu-link
In Drupal 8 there are separate .yml files for the menu links https://www.drupal.org/docs/8/api/menu-api/providing-module-defined-menu...

krina.addweb’s picture

krina.addweb commented
Status: Needs review » Needs work
StatusFileSize
new with_patch_hypothesis.png153.78 KB

@amarphule, Thanks for your efforts. I checked your patch and found that the menu link to the module settings page should be under Development section of the Admin > Configuration as per CR https://www.drupal.org/docs/8/creating-custom-modules/add-a-menu-link. Currently, it is under the Content Authoring section. PFA. Please correct if I am wrong.

amarphule’s picture

amarphule commented
Status: Needs work » Needs review

@krina.addweb, I had a discussion with maintainers and we packaged this module to Content. Moreover, Hypothesis is related to content annotation and sharing so this should go under system.admin_config_content.

satyanarayan reddy’s picture

satyanarayan reddy commented
StatusFileSize
new add-menu-link-of-the-module-settings-page-3050418-4.patch888 bytes
new screenshot-menu-2019.04.26-14-50-13.jpg52.93 KB

Menu under Development section

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Patch from #5 is not okay.

Patch from #2 is good.

I agree with the placement under Content Authoring, this is not a Development module.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented

rahul.shinde’s picture

rahul.shinde
he/him
Primary language Marathi
Location Pune
commented

Merged the patch.

rahul.shinde’s picture

rahul.shinde
he/him
Primary language Marathi
Location Pune
commented
Status: Reviewed & tested by the community » Fixed

Changing status to Fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.