Problem/Motivation

There is some duplicate code in the CredentialForm.php which needs to be addressed and by doing that it will make working on #2826742: Expose migration types in Migrate UI just a little easier. At least, I think so.

Proposed resolution

Have only one instance of calling setupMigrations() and the same for the block of code getting the legacy Drupal version. Also, move setupMigrations from FormBase to the CredentialForm since that is the only place it is used

Remaining tasks

Test the patch
Review

User interface changes

N/A

CommentFileSizeAuthor
#2 3049895-2.patch7.19 KBquietone
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Active » Needs review
FileSize
3049895-2.patch7.19 KB

Seems straightforward.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Status: Needs review » Reviewed & tested by the community

Looks fine. Just some simple code cleanup.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 8.8.x-dev » 8.7.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.8.x and cherry-picked to 8.7.x, thanks!

  • catch committed 6b8f6ad on 8.8.x 
    Issue #3049895 by quietone: Move setupMigrations to Credential form and...

  • catch committed 82e22c6 on 8.7.x 
    Issue #3049895 by quietone: Move setupMigrations to Credential form and...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.