Simple addition to check that a file is a file before we try to upload it. At least on OS X trying to upload a directory results in problems.

Some other trailing whitespace cleanups got rolled in by my editor.

CommentFileSizeAuthor
#2 simpletest_304940.patch1.13 KBdrewish
#1 simpletest_real_files.patch832 bytesboombatower
simpletest_real_files.patch2.56 KBdrewish

Comments

boombatower’s picture

boombatower commented
Status: Needs review » Needs work
StatusFileSize
new simpletest_real_files.patch832 bytes

I removed white-space clean-up since that is in several other patches and the rework patch should make in soon (#305077: Rework simpletest backend).

The upload test doesn't pass with this applied.

drewish’s picture

drewish commented
Status: Needs work » Needs review
StatusFileSize
new simpletest_304940.patch1.13 KB

ah, seems like the order of operations was getting wacky. this passes all the uploading (upload.module, blogapi.module, user.module) tests.

drewish’s picture

drewish commented
Status: Needs review » Reviewed & tested by the community

simple fix... still applies.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.