Closed (fixed)
Project:
Domain
Version:
2.0.x-dev
Component:
- Domain Source
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
17 Apr 2019 at 12:25 UTC
Updated:
6 Sep 2025 at 17:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
agentrickardThere is sample code in Drupal\domain_access\Plugin\Action that could be used to create these. I'm open to it.
Comment #3
slbrassard commentedAdded two types of actions: one for unset domain source and one for setting the domain source per domain.
Comment #4
slbrassard commentedComment #5
vflirt commentedI have tested it out and if the content is assigned to all affiliates it is not working. I also added extra update access check.
Comment #7
vflirt commentedAttaching proper file as there are new files added/
Comment #8
agentrickardLooks pretty good on first review.
It should really have a test. There is a similar one in domain/tests/src/Functional/DomainActionsTest.php
Comment #9
agentrickardComment #10
tim-dielsAfter testing, I'm not seeing the "Set" action for existing domains. These should be handled in the install function also and not only in the update function?
Also a small PHPCS issue with a t() that should be a $this-t() and another small PHPCS issue.
The tests are not that easy to add, so leaving that open and adding the issue tag.
Setting this to NR for the changes, can be set back to NW afterwards for the tests.
Comment #11
guardiola86 commentedThe patch is working for me. After running updates and clearing the cache, I can set the source origin. The only thing is that the domain must have already been checked in Domain Access, which is correct.
Comment #12
mably commentedCould we have a MR on 2.0.x please ?
Comment #14
mably commentedComment #15
mably commentedSimple test added. Looks like we are ready for merge.
Comment #17
mably commented