See the CR https://www.drupal.org/node/2119699

CommentFileSizeAuthor
#10 interdiff_2-10.txt673 bytesamarphule
#10 port-hook-menu-to-the-new-routing-system-3048142-10.patch1.23 KBamarphule
#2 port-hook-menu-to-the-new-routing-system-3048142-1.patch1.24 KBamarphule

Comments

amarphule created an issue. See original summary.

amarphule’s picture

amarphule commented
Assigned: amarphule » Unassigned
Status: Active » Needs review
StatusFileSize
new port-hook-menu-to-the-new-routing-system-3048142-1.patch1.24 KB

Created a routing.yml as per the CR https://www.drupal.org/node/2119699

rahul.shinde credited BramDriesen.

rahul.shinde credited ZhuRenTongKu.

rahul.shinde credited mmjvb.

rahul.shinde’s picture

rahul.shinde
he/him
Primary language Marathi
Location Pune
commented

rahul.shinde credited f2boot.

rahul.shinde’s picture

rahul.shinde
he/him
Primary language Marathi
Location Pune
commented
Issue tags: +#d8port
bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs review » Needs work 
+++ b/hypothesis.routing.yml
@@ -0,0 +1,9 @@
+hypothesis.admin_form:

If this is an configuration/settings form, this needs to be "hypothesis.settings".

+++ b/hypothesis.routing.yml
@@ -0,0 +1,9 @@
+    _permission: 'access administration pages'

You should create a custom permission for this.

Refer to the configuration-api page here: https://www.drupal.org/docs/8/api/configuration-api/working-with-configu...

amarphule’s picture

amarphule commented
Status: Needs work » Needs review
StatusFileSize
new port-hook-menu-to-the-new-routing-system-3048142-10.patch1.23 KB
new interdiff_2-10.txt673 bytes

Updated .routing.yml file as per suggested in the comment #9 and added interdiff

  • rahul.shinde committed 66123b7 on 8.x-1.x authored by amarphule 
    Issue #3048142 by amarphule, rahul.shinde, BramDriesen, ZhuRenTongKu,...
  • rahul.shinde committed d019de5 on 8.x-1.x
    Issue #3048142: Updated path as we have packaging this module for...
rahul.shinde’s picture

rahul.shinde
he/him
Primary language Marathi
Location Pune
commented
Status: Needs review » Fixed

I have merged the patch and updated menu path as well.

rahul.shinde’s picture

rahul.shinde
he/him
Primary language Marathi
Location Pune
commented
Parent issue: » #3012400: [hypothesis] Hypothesis

Adding parent.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.