Problem/Motivation

In order to be able to work in parallel on the configuration environment system and to avoid reviewing huge patches we need to be able to incrementally add new code in smaller scoped issues.

Proposed resolution

Add a empty experimental module placeholder which will contain the future work.

Remaining tasks

Add patch
review
commit

User interface changes

new module to select in the install UI.

API changes

none

Data model changes

n/a

Release notes snippet

n/a - we will have a release note snippet when the module becomes beta.

CommentFileSizeAuthor
#8 3047804-8.patch2.01 KBbircher
#8 interdiff-3047804-6-8.txt1.54 KBbircher
#6 3047804-4.patch2.03 KBricardoamaro
#3 3047804-3.patch987 bytesricardoamaro
#2 3047804-2.patch1015 bytesbircher
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bircher created an issue. See original summary.

bircher’s picture

bircher
Location 🇨🇿
CreditAttribution: bircher as a volunteer and commented
Status: Active » Needs review
FileSize
3047804-2.patch1015 bytes

Add patch with info file.

ricardoamaro’s picture

ricardoamaro CreditAttribution: ricardoamaro as a volunteer and at Acquia commented
FileSize
3047804-3.patch987 bytes

Added missing EOL

The last submitted patch, 2: 3047804-2.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 3: 3047804-3.patch, failed testing. View results

ricardoamaro’s picture

ricardoamaro CreditAttribution: ricardoamaro as a volunteer and at Acquia commented
Status: Needs work » Needs review
FileSize
3047804-4.patch2.03 KB

Added config_environment.module with help

Status: Needs review » Needs work

The last submitted patch, 6: 3047804-4.patch, failed testing. View results

bircher’s picture

bircher
Location 🇨🇿
CreditAttribution: bircher as a volunteer and commented
Status: Needs work » Needs review
FileSize
interdiff-3047804-6-8.txt1.54 KB
3047804-8.patch2.01 KB

I added a page in the drupal documentation.
And a link to it in the help hook.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented 
+++ b/core/modules/config_environment/config_environment.module
@@ -0,0 +1,21 @@
+      $output = '';
+      $output .= '<h3>' . t('About') . '</h3>';
+      $output .= '<p>' . t('The Configuration Environment module provides a mechanism for handling configuration changes between different environments. For more information, see the <a href=":config_environment">online documentation for the Configuration Environment module</a>.', [':config_environment' => 'https://www.drupal.org/node/3047873']) . '</p>';
+      return $output;

I think to be true to the current format we should add a Uses section here too BUT we don't have the UI or API yet so that feels premature. Perhaps a postponed issue in the roadmap will suffice.

Everything else looks great and once this is RTBC I will commit. I discussed this with @catch and all they wanted was more clarity on the roadmap.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented

I've added a step to address hook_help in the issue that will add the UI - ie. #3028179: Config Environment module (original issue)

mpotter’s picture

mpotter CreditAttribution: mpotter at Phase2 commented
Status: Needs review » Reviewed & tested by the community

Looks good. We can update help text as needed in future patches.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed 8b13e29 and pushed to 8.8.x. Thanks!

  • catch committed 8b13e29 on 8.8.x 
    Issue #3047804 by bircher, ricardoamaro, alexpott: Add scaffolding for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.