The docblock in core/modules/views/src/Plugin/views/ViewsHandlerInterface.php:33 contains a duplicate a.

   * Determines if the handler is considered 'broken', meaning it's a
   * a placeholder used when a handler can't be found.
CommentFileSizeAuthor
#11 Screen Shot 2019-04-12 at 12.54.16 PM.png19.52 KBehazell
#4 3047757-4.patch609 bytesex dj
#2 cleanup-comments-3047757-0.patch592 bytesradmosley

Comments

wolffereast created an issue. See original summary.

radmosley’s picture

radmosley commented
Status: Active » Needs review
StatusFileSize
new cleanup-comments-3047757-0.patch592 bytes

Removed additional "a" from comments

adrian_s_m’s picture

adrian_s_m commented

Hi all,

I'm a newbie at DrupalCon and I will take a look at this/review!

ex dj’s picture

ex dj commented
StatusFileSize
new 3047757-4.patch609 bytes

Have a patch for testing. Total noob.

luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented

It looks like the patch in #4 is also making a filemode change. Git can be configured to ignore file mode changes by setting `core.fileMode` to false.

https://git-scm.com/docs/git-config#EXAMPLES has some examples on how to do that. :)

ehazell’s picture

ehazell commented
Status: Needs review » Needs work

patch #4 is a bad patch as it add the "a" back in. I am at DrupalCon Seattle and working on this now.

wolffereast’s picture

wolffereast commented
Status: Needs work » Needs review

The patch in #4 isn't good, but the patch in #2 passed testing and is ready for review. I have reviewed and it looks good to me. Wouldn't hurt to get a second opinion from one of the other commentors.

ehazell’s picture

ehazell commented
Status: Needs review » Reviewed & tested by the community

Patch #2 does what is expected as it removes the additional "a" and doesn't have the file mode issue.

wolffereast’s picture

wolffereast commented
adrian_s_m’s picture

adrian_s_m commented

I downloaded the patch #2 and tested it. It applied cleanly and everything seems to work for me!
Thanks, @jnicola for the help with the instructions in regards to testing and review!

ehazell’s picture

ehazell commented
StatusFileSize
new Screen Shot 2019-04-12 at 12.54.16 PM.png19.52 KB

here is the screenshot after i had applied the patch

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

@ehazell there's no need to provide a screenshot.

I've credited @ehazell, @wolffereast, @Adrian_S_M and @Luke.Leber for issue review and all have provided comments which detail what actions they took or contributed to getting to the correct patch.

I considered removing credit for @ex DJ because the patch in #4 didn't do the task and in fact undid the patch in #2. However on consideration this is there first issue that they will get credit on I decided that this was an honest mistake and that their effort in contributing should get a credit.

Committed and pushed 37fe072f79 to 8.8.x and 356774b7e0 to 8.7.x. Thanks!

Backported to 8.7.x as a docs fix.

  • alexpott committed 37fe072 on 8.8.x 
    Issue #3047757 by radmosley, ex DJ, ehazell, wolffereast, Adrian_S_M,...

  • alexpott committed 356774b on 8.7.x 
    Issue #3047757 by radmosley, ex DJ, ehazell, wolffereast, Adrian_S_M,...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 8.8.x-dev » 8.7.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.