The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.The feature to not load the Quicklink library on certain content types is working the opposite to how it's intended.
For example, if I configure the module with all of my content types unchecked, then when I visit a node page I would expect the Quicklink library to be loaded. However, when I visit a node page in this scenario, the debug load shows: "Library not loaded because content type 'page' is specified to not load library."
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | quicklink-content-types-3047485-6.patch | 640 bytes | mherchel |
| #5 | quicklink.13066818-4.patch | 630 bytes | mherchel |
| #4 | drupal-7_64____sites_drupal-7_64__-___sites_quicklink-d7_quicklink_module.png | 106.49 KB | mherchel |
| #2 | quicklink-content-types-3047485-2.patch | 591 bytes | joelstein |
Comments
Comment #2
joelstein commentedThis patch fixes the issue by inverting the faulty logic.
Comment #3
mherchelThanks :) On way back from DrupalCon now. Will be reviewing it this weekend!
Comment #4
mherchelLooking in xdebug, it seems like we need to do more than check to see if the content type is in the array
Comment #5
mherchelAttached is an updated patch that checks for
$no_load_content_types[$node->type]. Take a look?Comment #6
mherchelRe-rolled patch against latest HEAD
Comment #8
mherchelJust finished more testing of this feature. I'm happy with it. Committing. Thanks @joelstein
Comment #9
joelstein commentedGreat, thanks for getting this in!
Just an FYI, "in_array()" checks if the value is in the array, not the key. So the patch I submitted should work just fine; but what you have also works. :)