Needs work
Project:
SAML Authentication
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
9 Apr 2019 at 14:19 UTC
Updated:
18 Apr 2021 at 15:27 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
interx commentedComment #3
interx commentedHere's a new patch that includes some minor changes and the patch from #3046158. This was needed to merge both cleanly, as they both need to save the user account and add an API documentation file.
Comment #4
interx commentedI needed another hook to disallow some users based on a SAML attribute. New patch attached.
Comment #5
interx commentedRerolled the patch with the fix from #3046158: Sync data on each login added (issue when account with email already exists).
Comment #6
roderikThat's a daunting amount of new hooks, which I fear may introduce confusion about what to use when.
I haven't thought through all the details of my questions below, but some of them are informed by the structure of the D8 code.
Connected to the first bullet point:
Separately:
The use of the 'samlauth_roles_required_saml_roles' is... you want to block users who don't have a certain role, from logging in through SAML, while not blocking them from logging in locally? That's interesting, as the D8 version has it the other way around.
(Except there, it's a permission, not a role.)