Looking at other CKEditor plugin modules and some of the documentation on drupal.org, it seems to be a defacto standard to have ckeditor plugins in libraries/ckeditor/plugins/pluginname.

This makes sense since it removes the risk of confusion and conflicts with non-ckeditor libraries that might have the same name and CKEditor's default instructions are to put plugins in a plugins sub-directory, which is what Drupal core does with its default CKEditor plugins.

If we can get consistency with where CKEditor plugin modules store their libraries it also makes it easier to manage all CKEditor plugins in a uniform manner.

CommentFileSizeAuthor
#2 support-installing-plugin-libraries-ckeditor-plugins-3046781-2.patch557 bytesjulianvj

Comments

rooby created an issue. See original summary.

julianvj’s picture

julianvj commented
StatusFileSize
new support-installing-plugin-libraries-ckeditor-plugins-3046781-2.patch557 bytes

Attached patch to modify libraries path to ' libraries/ckeditor/plugins/templates' as @rooby said and as the documentation suggests: https://www.drupal.org/docs/8/core/modules/ckeditor/managing-ckeditor-pl...

jacine’s picture

jacine
she/her
Location New York
commented
Status: Active » Needs review

I agree it would be better to allow installation at libraries/ckeditor/plugins/templates. I tested the patch, and it works. Though, depending on what the maintainer wants to do, it might be better to support both locations, or be able to configure the location in settings. This patch simply changes the location, which will break existing sites. Setting to "Needs review" for now, pending maintainer feedback.

  • lucaslg committed 2fdf170 on 8.x-1.x 
    Issue #3046781 by JulianVJ, Jacine: Support installing plugin to...
lucaslg’s picture

lucaslg commented
Status: Needs review » Fixed

Thank you for your suggestion rooby and your patch JulianVJ.

As Jacine pointed out, it feels better to keep compatibility with existing path to avoid a breaking change in the next version. Thus, users are free to do has they want.

Because I don't have much time to work on this module (as you can see from my response time...), I directly commited the change so that I don't have to come back to it.

Another improvement would be, as suggested in the link JulianJV provided, to use composer to install the ckeditor library. I will create another issue for this one.

lucaslg’s picture

lucaslg commented

Created the composer issue : #3142359: Install Ckeditor plugin through composer

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.