This module allows users and visitors to quickly send feedback messages about the currently displayed content. This helps website admins in quality assurance of their pages, content.
Content Feedback form is submitted via AJAX, users can continue using the site on same page after posting content feedback. Allowed to display globally or for only selected content types. Admin can exclude feedback form for selected urls.
Content feedback messages are listed and grouped by status in an administrative feedback list. Admin can review and update status to 'Resolved' for the fixed feedback.
https://www.drupal.org/project/content_feedback
git clone --branch 8.x-1.x https://git.drupalcode.org/project/content_feedback.git
https://pareview.sh/pareview/https-git.drupal.org-project-content_feedba...
Comments
Comment #2
nikhilesh gupta commentedComment #3
klausiThanks for your contribution!
Review:
* content_feedback_access_block(): I would check for user access first before doing anything else.
* AdminFeedbackController doc block: I see that this class extends ControllerBase. But what is its purpose? A class comment should describe what the class is doing and its responsibility.
* "$resolvedFeedbacks = 'There are no processed content feedbacks.';": all user facing text must run through $this->t() for translation. Please check all your strings.
* AdminFeedbackController: do not call render(), just return the render array. Drupal core will render it later for you.
* AdminFeedbackController: this will not scale if you have received many feedback entries and the database tries to return thousands of entries. Yopu will need to implement a pager to only display a limited set, otherwise user will run into timeouts or memory limit issues. I would define your feedback rows as Drupal entities and then leverage the entity API which has support for Views where you can easily display and configure pagers.
* AddContentFeedback::buildForm(): do not create a Request from globals, use ->getRequest() instead.
* AddContentFeedback::submitForm(): Why is this function empty? Can you remote it? If not please add a comment in code.
* drupal_set_message() is deprecated. Please use the messenger service instead.
Otherwise looks good to me!
Comment #4
nikhilesh gupta commented@klausi Thanks for the review. I have made the suggested changes.
Comment #5
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.