Make sure other tags are not lost on rest resources

The remove might even support wildcards/regular expressions.

Hmm my initial tests showed otherwise. Will review again

@berdir

This is with the default Tag cache:

X-Drupal-Cache-Tags: config:field.storage.node.field_breadcrumb_label config:field.storage.node.field_key_cta config:field.storage.node.field_key_flexible_tag config:field.storage.node.field_key_image config:field.storage.node.field_key_teaser config:field.storage.node.field_key_title config:field.storage.node.field_key_type_feed config:user.role.anonymous config:views.view.media_feed http_response node:120038 node:121550 node:121560 node:121563 node:122221 node:122341 node:122344 node:126689 node:2160 node:2605 node_list taxonomy_term:13 taxonomy_term:150 taxonomy_term:190 taxonomy_term:196 taxonomy_term:197 taxonomy_term:198 taxonomy_term_list

And this is with the custom tag module and node_list:media as the tag:

X-Drupal-Cache-Tags: config:field.storage.node.field_breadcrumb_label config:field.storage.node.field_key_cta config:field.storage.node.field_key_flexible_tag config:field.storage.node.field_key_image config:field.storage.node.field_key_teaser config:field.storage.node.field_key_title config:field.storage.node.field_key_type_feed config:user.role.anonymous config:views.view.media_feed http_response node_list:media

So it seems that the single entities are also removed or am I understanding it wrong?

It's a rest export and has a custom serializer, but I just tried a brand new one on a local bare d8 and confirmed that it does work as you said on a regular page, but not on a rest export (core serializer) url.

Well, you are not calling the parent getCacheTags().

See this patch. It was a quick PoC but if may very well be the fix if you are happy with it. I'd say thought that it wasn't clear for me that this module just replaces the entity_list.

Well, something is adding it, the above works. It seems to be

$tags = Cache::mergeTags($tags, $this->view->getQuery()->getCacheTags());

which is the only thing you are not calling on your own.

From CachePluginBase::getCacheTags()

Commenting it does the same as the module. It seems that on the rest export, the above adds the entity tags on rest, not on regular page. On a regular page view the entity ids come from

$tags = $this->view->storage->getCacheTags();

I'd think is best to call the parent and then remove so to not depend on what core does.

Looking into the tests though. Is this patch not likely to be accepted?

Tests were failing because of #3045855: Fix tests - views schema and new http_response cache tag, unrelated to this.

I worked yesterday on testes for this patch, will send it in a min.

Adding tests to the patch.

I tried to keep the test a mirror of the other but assertPageCacheContextsAndTags didn't work nicely for json responses. I overrode it but also submitted #3046128: Extend assertPageCacheContextsAndTags tu support other request formats to core. If that is accepted the overrode method could be removed.

@Berdir I took me a while but I got what you meant. My rationale behind filtering out is that uf core decides to do something else or different we just need to catch up with the removing of it, not with what is added/changed.

If you are really opposed to it, I can rework the patch.