The cookies from this module have the path hardcoded to '/'. It would be better if they used 'base_path()' instead so that multiple drupal sites on the same domain do not leak cookies between them.

CommentFileSizeAuthor
#2 cookies_hardcoded-3044865-2.patch749 bytessergiu stici

Comments

dudleyc created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
StatusFileSize
new cookies_hardcoded-3044865-2.patch749 bytes

I changed it, here is the patch.

  • nortmas committed dc67c69 on 8.x-1.x 
    #3043363 - user.tempstore.expire is deprecated, #3044865 - Cookies...

  • nortmas committed 4e4b134 on 8.x-1.x 
    #3043363 - user.tempstore.expire is deprecated, #3044865 - Cookies...

  • nortmas committed fcd0f7c on 8.x-1.x 
    #3043363 - user.tempstore.expire is deprecated, #3044865 - Cookies...

  • nortmas committed bb8af5a on 8.x-1.x 
    #3043363 - user.tempstore.expire is deprecated, #3044865 - Cookies...
nortmas’s picture

nortmas commented
Status: Needs review » Fixed

Thank you for the research. I've done it in a bit more flexible way. Now you can set the path as a third argument of the get method.
I've also mentioned it in the module description.

nortmas’s picture

nortmas commented
Status: Fixed » Closed (fixed)