A11Y Paragraphs Tabs gives the user the ability to easily add tabs via paragraphs to their content that complies to Accessibility (A11Y) standards. On Desktop it shows Tabs and on mobile it displays as an accordion.

This module adds paragraphs that are already configured to give you tabs on desktop and an accordion on mobile. You do not need to configure anything.

A11Y Paragraphs Tabs uses Matthias Ott's A11Y Accordion Tabs js:
https://github.com/matthiasott/a11y-accordion-tabs

Project page

https://www.drupal.org/project/a11y_paragraphs_tabs

Git Instructions

git clone --branch 8.x-1.x https://git.drupalcode.org/project/a11y_paragraphs_tabs.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-a11y_paragraph...

Comments

hmartens created an issue. See original summary.

hmartens’s picture

Title: [D8] A11Y Paragraohs Tabs » [D8] A11Y Paragraphs Tabs

Fixed mistyped title.

avpaderno’s picture

Issue summary: View changes
Status: Active » Needs review

Thank you for your contribution! I added the PAReview checklist. Reviewers will soon check the code and report here what they found out.

If you still haven't done it, please check what reported from the PAReview checklist. There could be some false positives; be careful of not changing code that should not be.

hmartens’s picture

Thank you. I will fix the issues shown by the PAReview. Thank you for this.

avpaderno’s picture

Remember to remove also the LICENSE.txt file. That is added automatically from drupal.org when packaging the files.

hmartens’s picture

Hi Alberto, I pushed code this morning that removed the License.txt file. I pushed that before I applied for the security consideration. It's weird that you are still seeing it.

Also, the PAReview mentions the .DS_Store files but I do not see anything when I "ls" in my folder. Is that a false positive or is it still there and I am just not seeing it?

Thank you for your help.

avpaderno’s picture

Files whose name starts with a dot are hidden. You should see them with ls -als.

The last commit drupal.org reports for the project has been done on March 16, 2019. Drupal.org is now using Gitlab, and it's probable there are changes to do on the local repository. I have read a page on drupal.org about that, but I don't remember where.

hmartens’s picture

Hi Alberto, that is very strange because I created a new tag this morning and on the project page on drupal.org I created a new release and tagged it according to the new tag. If I didn't create the new tag, it wouldn't be available for me to select when I created a new release. Because I am currently on version 8.x-1.1 .

With the moving over to gitlab in mind, I deleted my repo on my local and deleted the entry in the known_hosts and cloned the repo again.

hmm...this is very strange. I downloaded the module now, the version 8.x-1.1 and it does not have my changes that I committed this morning. but it did pick up my 1.1 tag...very strange.

Let me investigate what went wrong :) Thanks for the headsup. I appreciate it.

hmartens’s picture

Hi Alberto. I have worked out the issue I was having. I was pushing the tags before pushing the code. So I fixed that. I am now on version 8.x-1.3 and that should also fix some of the PAReview comments.

hmartens’s picture

I fixed the remainder of the line exceeds 80 charecters on 1.x-1.3 and pushed to tag 8.x-1.4 . So those small issues should all be fixed.

I also can't find any .DS_Store files in my folder?

Then there is 2 remaining issues which I don't know how to sort out:
- "The a11y_paragraphs_tabs.module does not implement hook_help()"
- "No automated test cases were found"

But I will look into these now :)

hmartens’s picture

Hi Alberto

I have fixed all issues on PAReview including the help_hook().

I just don't have any automated testing. But all the rest of the issues that was picked up on PAReview are fixed now.

Thanks for your help.

klausi’s picture

Status: Needs review » Reviewed & tested by the community

All looking good to me!

avpaderno’s picture

Assigned: Unassigned » avpaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

hmartens’s picture

Thank you everyone for reviewing my first Drupal module contribution ;) I appreciate it!

hmartens’s picture

Alberto, how long does it take to get the green on a module page once it's been approved for security cover?

avpaderno’s picture

You need to edit the project and opt into security coverage. The project needs to be created more than two weeks ago, or it's not possible to opt in.

hmartens’s picture

Hi Alberto

Thanks, I edited my module and opt in to security. So I have the shield now. When will my module turn to green? It's currently yellow.

Thank you for your help!

klausi’s picture

You need to set it as recommended major version at the "Releases" tab.

hmartens’s picture

Awesome thanks Klaus! I appreciate your help. I have changed it and my module is now green! I am so happy :)

Thanks for the awesome support!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.