Problem/Motivation

As a public service, LayoutBuilderSampleEntityGenerator should have an interface.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 3043825-generator-4-interdiff.txt463 bytestim.plunkett
#4 3043825-generator-4.patch6.31 KBtim.plunkett
#2 3043825-generator-2.patch6.31 KBtim.plunkett

Comments

tim.plunkett created an issue. See original summary.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new 3043825-generator-2.patch6.31 KB
johnwebdev’s picture

johnwebdev commented 
+++ b/core/modules/layout_builder/src/Entity/SampleEntityGeneratorInterface.php
@@ -0,0 +1,36 @@
+

Nit: Extra newline

Otherwise looks good. I like the naming of the interface, removing the LayoutBuilder prefix. Thinking this interface could be useful outside of Layout Builder some day in the future.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
StatusFileSize
new 3043825-generator-4.patch6.31 KB
new 3043825-generator-4-interdiff.txt463 bytes

Glad you agree! Fixed the blank line

johnwebdev’s picture

johnwebdev commented
Status: Needs review » Reviewed & tested by the community
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented

Change record added: https://www.drupal.org/node/3043943

The interface docs seem basic, but this is very specific to Layout Builder (at least for now), and not much of an API. So that shouldn't be a problem. +1 RTBC.

xjm’s picture

xjm
she/her
Primary language English
commented

Saving credit.

  • xjm committed a10a712 on 8.8.x 
    Issue #3043825 by tim.plunkett, johndevman, phenaproxima: Create an...

  • xjm committed e7a4100 on 8.7.x 
    Issue #3043825 by tim.plunkett, johndevman, phenaproxima: Create an...
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.8.x, cherry-picked to 8.7.x, and published the change record. Thanks!

johnwebdev’s picture

johnwebdev commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.