Closed (fixed)
Project:
Drupal core
Version:
8.8.x-dev
Component:
layout_builder.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
27 Mar 2019 at 14:36 UTC
Updated:
16 Apr 2019 at 12:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
tim.plunkettComment #3
johnwebdev commentedPatch looks good to me, making it public is also nice for contrib if they need to extend it (i.e. thinking of asymmetric translation if we decide it should not be part of core).
Comment #4
phenaproximaChange record written: https://www.drupal.org/node/3043944.
The interface docs look pretty basic, but it doesn't need to be elaborate at this point, since the inline block stuff isn't really an API. We can beef up the docs later as needed! +1 RTBC.
Comment #7
xjmYeah there's a couple small oddities in the docs, e.g.:
Extra "the".
However, since this is essentially moved code, fixing up the docs is out of scope.
That said:
Fixed on commit like so:
Committed to 8.8.x, cherry-picked to 8.7.x, and published the change record. Thanks!
Comment #8
johnwebdev commented