Still have to debug this more:

[05-Sep-2008 11:02:35] PHP Fatal error:  Maximum execution time of 30 seconds exceeded in /Users/dries/Sites/drupal-cvs/includes/common.inc on line 2692
[05-Sep-2008 11:02:35] PHP Stack trace:
[05-Sep-2008 11:02:35] PHP   1. {main}() /Users/dries/Sites/drupal-cvs/index.php:0
[05-Sep-2008 11:02:35] PHP   2. menu_execute_active_handler() /Users/dries/Sites/drupal-cvs/index.php:17
[05-Sep-2008 11:02:35] PHP   3. call_user_func_array() /Users/dries/Sites/drupal-cvs/includes/menu.inc:397
[05-Sep-2008 11:02:35] PHP   4. system_batch_page() /Users/dries/Sites/drupal-cvs/includes/menu.inc:0
[05-Sep-2008 11:02:35] PHP   5. _batch_page() /Users/dries/Sites/drupal-cvs/modules/system/system.admin.inc:1881
[05-Sep-2008 11:02:35] PHP   6. _batch_do() /Users/dries/Sites/drupal-cvs/includes/batch.inc:41
[05-Sep-2008 11:02:35] PHP   7. _batch_process() /Users/dries/Sites/drupal-cvs/includes/batch.inc:113
[05-Sep-2008 11:02:35] PHP   8. call_user_func_array() /Users/dries/Sites/drupal-cvs/includes/batch.inc:198
[05-Sep-2008 11:02:35] PHP   9. _simpletest_batch_operation() /Users/dries/Sites/drupal-cvs/includes/batch.inc:0
[05-Sep-2008 11:02:35] PHP  10. DrupalWebTestCase->run() /Users/dries/Sites/drupal-cvs/modules/simpletest/simpletest.module:365
[05-Sep-2008 11:02:35] PHP  11. DrupalWebTestCase->setUp() /Users/dries/Sites/drupal-cvs/modules/simpletest/drupal_web_test_case.php:283
[05-Sep-2008 11:02:35] PHP  12. menu_rebuild() /Users/dries/Sites/drupal-cvs/modules/simpletest/drupal_web_test_case.php:668
[05-Sep-2008 11:02:35] PHP  13. _menu_navigation_links_rebuild() /Users/dries/Sites/drupal-cvs/includes/menu.inc:1707
[05-Sep-2008 11:02:35] PHP  14. menu_link_save() /Users/dries/Sites/drupal-cvs/includes/menu.inc:1799
[05-Sep-2008 11:02:35] PHP  15. drupal_alter() /Users/dries/Sites/drupal-cvs/includes/menu.inc:1893
[05-Sep-2008 11:02:35] PHP  16. is_array() /Users/dries/Sites/drupal-cvs/includes/common.inc:2692
CommentFileSizeAuthor
#19 304328-set-time-limit-simpletest-4.patch2.59 KBBartVB
#12 304328-set-time-limit-simpletest-3.patch2.93 KBdamien tournoud
#10 304328-set-time-limit-simpletest-2.patch2.93 KBdamien tournoud
#7 304328-set-time-limit-simpletest.patch684 bytesdamien tournoud
crash-tests.png17.36 KBdries

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Do you get that from the outset? I'm getting a timeout error on #296310: TestingParty08: drupal_http_request redirects need a test when I run that particular test, but the rest pass for me.

catch’s picture

catch
he/him
Primary language English
commented

This has popped up a few times, I also had to increase max_execution_time on my laptop. See http://groups.drupal.org/node/11993#comment-43068 for another example.

cwgordon7’s picture

cwgordon7 commented
Category: bug » support
Status: Active » Fixed

You need to increase maximum php execution time, especially on slower machines.

damien tournoud’s picture

damien tournoud commented
Category: support » bug
Status: Fixed » Postponed (maintainer needs more info)

I would like we dig into this one further. If I remember correctly, we had a set_time_limit(0) somewhere in the code, but we lost it somehow.

catch’s picture

catch
he/him
Primary language English
commented
Title: Tests are failing for me » SimpleTest requires max_execution_time > 30 seconds
Status: Postponed (maintainer needs more info) » Active

Retitling, would be good to fix this, or at a minimum add a hook_requirements() for it.

boombatower’s picture

boombatower commented

How about we get #295697: Increase PHP Memory Limit for Simpletest in first since these are related.

damien tournoud’s picture

damien tournoud commented
Status: Active » Needs review
StatusFileSize
new 304328-set-time-limit-simpletest.patch684 bytes
pwolanin’s picture

pwolanin commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs work

Let's get a hook_requirements() in there, please.

damien tournoud’s picture

damien tournoud commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new 304328-set-time-limit-simpletest-2.patch2.93 KB

Ok, this should do it.

damien tournoud’s picture

damien tournoud commented
Status: Reviewed & tested by the community » Needs review
damien tournoud’s picture

damien tournoud commented
StatusFileSize
new 304328-set-time-limit-simpletest-3.patch2.93 KB

Oups, negated a condition.

pwolanin’s picture

pwolanin commented

hmm, still problematic I think - on a host with a long max execution time but where the client is not allowed to call set_time_limit() simpletest will install, but still throw errors. Can you use init_set() instead?

boombatower’s picture

boombatower commented
Component: base system » simpletest.module
dries’s picture

dries commented

BTW, increasing the max_execution_time fixed this problem for me.

dries’s picture

dries commented

My problem might not have been detected by this patch. I had xdebug turned on with excessive profiling and logging to files. This slowed down Simpletest by a factor X causing the above error to happen. I can try to reproduce that setup to see if this solves the problem.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Dries: Also be careful of xdebug spitting stuff out into the browser. Batch API dies horribly if there are headers printed before it thinks they ought to be printed, it seems.

I have seen this error cause problems for other people (poor pwolanin was ripping his hair out the other night because he was getting intermittent failures in the db tests because of this), so it's still worth fixing this issue.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work

The last submitted patch failed testing.

BartVB’s picture

BartVB commented
StatusFileSize
new 304328-set-time-limit-simpletest-4.patch2.59 KB

Bumped into this bug when trying out SimpleTest, patch seems to work but doesn't solve my problem. I get:

An HTTP error 0 occurred.
/drupal/?q=batch&id=10&op=do

which seems to be some sort of HTTP timeout and not an execution time problem. When I get the message the test is still running.

Rerolled to patch to make testing.drupal.org happy :)

boombatower’s picture

boombatower commented
Status: Needs work » Closed (fixed)

We have max execution code in SimpleTest, believe that fixes this.