Problem/Motivation

drupal-check results on commit hash:
source : [git] https://git.drupal.org/project/select_or_other 1e1e6708240117206ab239eab51ec2ede7dc5cdb
source : http://cgit.drupalcode.org/select_or_other 


 ------ ---------------------------------------------- 
  Line   Tests/src/Unit/ReferenceWidgetTest.php        
 ------ ---------------------------------------------- 
  153    Call to deprecated method getMock() of class  
         Drupal\Tests\UnitTestCase.                    
 ------ ---------------------------------------------- 

 ------ -------------------------------------------------------------------- 
  Line   Tests/src/Unit/SelectOrOtherWidgetBaseTest.php                      
 ------ -------------------------------------------------------------------- 
         Class                                                               
         Drupal	ests\select_or_other\Unit\SelectOrOtherWidgetBaseTest was   
         not found while trying to analyse it - autoloading is probably not  
         configured properly.                                                
 ------ -------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------ 
  Line   src/Plugin/Field/FieldWidget/EntityReference/ReferenceWidget.php  
 ------ ------------------------------------------------------------------ 
  192    Call to deprecated method entityManager() of class Drupal.        
 ------ ------------------------------------------------------------------ 

 [ERROR] Found 3 errors

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#11 select_or_other_not_ready_for_Drupal_9_in_update_status_module_report.png34.52 KBfrederickjh
#6 3042965-6.patch1.01 KBrpayanm
#5 drupal_9_deprecated_code-3042965-5.patch656 bytesamateichuk
#2 drupal_9_deprecated_code-3042965-2.patch9.31 KBsergiu stici

Comments

mcdwayne created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
StatusFileSize
new drupal_9_deprecated_code-3042965-2.patch9.31 KB

Here is the patch, please review.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented

Thanks for doing this work, but unfortunately 8.x-3.x is not being worked on and is very stale. 8.x-1.x is the active branch for this module.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Version: 8.x-3.x-dev » 8.x-1.x-dev
Status: Needs review » Needs work
amateichuk’s picture

amateichuk commented
Status: Needs work » Needs review
StatusFileSize
new drupal_9_deprecated_code-3042965-5.patch656 bytes

18/18 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ ---------------------------------------------------------------
Line tests/src/Functional/TestBase.php
------ ---------------------------------------------------------------
161 Call to deprecated function entity_get_form_display():
as of Drupal 8.0.x, will be removed before Drupal 9.0.0.
If the entity form display is available in configuration use:
------ ---------------------------------------------------------------

[ERROR] Found 1 error

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
StatusFileSize
new 3042965-6.patch1.01 KB

The patch looks good but it's missing the change in the .info.yml file

18/18 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[OK] No errors

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Status: Needs review » Fixed

Looks good to me. Committed and pushed to 8.x-1.x. Thanks!

  • legolasbo committed 32d95ed on 8.x-1.x authored by rpayanm 
    Issue #3042965 by Sergiu Stici, Tolyan4ik, rpayanm, legolasbo: Drupal 9...
rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

frederickjh’s picture

frederickjh
he/him
Primary language English
Location The Big Island of Hawai'i
commented
StatusFileSize
new select_or_other_not_ready_for_Drupal_9_in_update_status_module_report.png34.52 KB

I know this has been closed but here we are almost a year later and the committed sits in the development branch. How about a release for those working on moving to Drupal 9?

The Update Status module lists only this module under the "Collaborate with maintainers" section on one site I maintain.

Update Status Module list Select or Other in the Collaborate with maintainers section of its report

Christopher Riley’s picture

Christopher Riley commented

Bump

daften’s picture

daften commented

I will create a new release later today, in a new semver branch.