Problem/Motivation

Quoting #2948828-145: Layout Builder's Field Blocks do not work with Quick Edit:

Ok this patch goes patch removing testLayoutBuilderRenderPipelineForQuickEdit() because seems impossible and beyond the scope of the issue to make random test failure proof QuickEdit test for Layout builder. In HEAD the \Drupal\Tests\quickedit\FunctionalJavascript\QuickEditIntegrationTest which is QuickEdit's own tests fail randomly already. So that will need to be fixed in #3037436: [random test failure] Make QuickEditIntegrationTest more robust and fail proof

[…]
I talked with @xjm, @tim.plunkett and @Wim Leers and we agreed that this best we can for test coverage given the existing random failures in QuickEdit tests.

Proposed resolution

#2948828: Layout Builder's Field Blocks do not work with Quick Edit should land shortly, and then after #3037436: [random test failure] Make QuickEditIntegrationTest more robust and fail proof is fixed we'll be able to bring back \Drupal\Tests\quickedit\FunctionalJavascript\QuickEditIntegrationTest::testLayoutBuilderRenderPipelineForQuickEdit.

Remaining tasks

  1. Wait for #2948828: Layout Builder's Field Blocks do not work with Quick Edit -> [PP-1] then
  2. Wait for #3037436: [random test failure] Make QuickEditIntegrationTest more robust and fail proof -> not postponed on anything anymore then
  3. Re-review the test coverage on this issue, perhaps adjusting based on changed in #3037436: [random test failure] Make QuickEditIntegrationTest more robust and fail proof
  4. Commit.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

None.

CommentFileSizeAuthor
#2 3042870-2.patch3.44 KBwim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes
StatusFileSize
new 3042870-2.patch3.44 KB

This is on top of #2948828-145: Layout Builder's Field Blocks do not work with Quick Edit.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Parent issue: » #3043536: [meta] Refactoring of Layout Builder tests

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

catch’s picture

catch
he/him
Primary language English
commented
Title: [PP-2] Follow-up for #2948828: add test coverage for Layout Builder's custom Quick Edit render pipeline once Quick Edit integration tests have been stabilized » Follow-up for #2948828: add test coverage for Layout Builder's custom Quick Edit render pipeline once Quick Edit integration tests have been stabilized
Status: Postponed » Active

Tentatively re-opening after #3082602: Remove transform rule from css_disable_transitions_test.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

dww’s picture

dww
we/he/they
commented

Is this issue relevant anymore now that we're moving quickedit back to contrib? Closed (outdated)? Won't fix? Move projects so the issue can be forgotten and die there? ;) Please advise the new quickedit (non)maintainer.

Thanks!
-Derek

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

danielveza’s picture

danielveza
he/him
Location Brisbane, AU
commented

I'm going through and triaging LB issues. It would be good to get an update/some thoughts on this one. I'm leaning towards marking it as outdated based on #11

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.