Problem/Motivation

Twig return type on resolveTemplate keeps changing, in 1.38.4, it now returns Template by default instead of Template wrapper causing tests to fail.

Proposed resolution

No core code seems to use ->resolveTemplate() except for the three instances noted in the patch. Therefore, it should be safe to change the tests over to use->load

Remaining tasks

commit it

User interface changes

none

API changes

none

Data model changes

none

Release notes snippet

CommentFileSizeAuthor
#2 3042848-2.drupal.use-load-instead-of-resolveTemplate-in-Twig-Resolver-tests.patch1.87 KBmikelutz

Comments

mikelutz created an issue. See original summary.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Active » Needs review
StatusFileSize
new 3042848-2.drupal.use-load-instead-of-resolveTemplate-in-Twig-Resolver-tests.patch1.87 KB
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Nice one.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Issue summary: View changes

I just double checked and confirmed we don't use ->resolveTemplate anywhere else in core, so it should be safe to change the tests to ->load

catch’s picture

catch
he/him
Primary language English
commented
Version: 8.8.x-dev » 8.7.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed b0a741c568 to 8.8.x and eef22b0158 to 8.7.x. Thanks!

  • catch committed b0a741c on 8.8.x 
    Issue #3042848 by mikelutz: use ->load() instead of ->resolveTemplate in...

  • catch committed eef22b0 on 8.7.x 
    Issue #3042848 by mikelutz: use ->load() instead of ->resolveTemplate in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.