Problem/Motivation

drupal-check results on commit hash:
source : [git] https://git.drupal.org/project/key_value 5a24b5998f309ab17a2b79c88362f4c7f11265fa
source : https://git.drupal.org/project/key_value.git 


 ------ ------------------------------------------------------ 
  Line   src/Tests/DatabaseStorageListTest.php                 
 ------ ------------------------------------------------------ 
  38     Call to deprecated method assertEqual() of class      
         Drupal\KernelTests\KernelTestBase.                    
  41     Call to deprecated method assertIdentical() of class  
         Drupal\KernelTests\KernelTestBase.                    
  48     Call to deprecated method assertIdentical() of class  
         Drupal\KernelTests\KernelTestBase.                    
  52     Call to deprecated method assertIdentical() of class  
         Drupal\KernelTests\KernelTestBase.                    
 ------ ------------------------------------------------------ 

 ------ ------------------------------------------------------ 
  Line   src/Tests/DatabaseStorageSortedSetTest.php            
 ------ ------------------------------------------------------ 
  48     Call to deprecated method assertEqual() of class      
         Drupal\KernelTests\KernelTestBase.                    
  51     Call to deprecated method assertIdentical() of class  
         Drupal\KernelTests\KernelTestBase.                    
  54     Call to deprecated method assertIdentical() of class  
         Drupal\KernelTests\KernelTestBase.                    
  57     Call to deprecated method assertIdentical() of class  
         Drupal\KernelTests\KernelTestBase.                    
  60     Call to deprecated method assertIdentical() of class  
         Drupal\KernelTests\KernelTestBase.                    
  66     Call to deprecated method assertIdentical() of class  
         Drupal\KernelTests\KernelTestBase.                    
  70     Call to deprecated method assertIdentical() of class  
         Drupal\KernelTests\KernelTestBase.                    
  73     Call to deprecated method assertEqual() of class      
         Drupal\KernelTests\KernelTestBase.                    
  76     Call to deprecated method assertEqual() of class      
         Drupal\KernelTests\KernelTestBase.                    
 ------ ------------------------------------------------------ 

 ------ ------------------------------------------------------ 
  Line   src/Tests/DatabaseStorageSortedTestBase.php           
 ------ ------------------------------------------------------ 
  49     Call to deprecated method assertIdentical() of class  
         Drupal\KernelTests\KernelTestBase.                    
  51     Call to deprecated method assertIdentical() of class  
         Drupal\KernelTests\KernelTestBase.                    
  62     Call to deprecated method assertEqual() of class      
         Drupal\KernelTests\KernelTestBase.                    
 ------ ------------------------------------------------------ 

 [ERROR] Found 16 errors

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#14 interdiff-3042817-10-14.txt346 bytesmrinalini9
#14 3042817--14.patch5.38 KBmrinalini9
#10 3042817--10.patch4.98 KBshubhangi1995
#4 3042817-4.patch17.3 KBbramdriesen
#2 3042817-2.patch4.46 KBbramdriesen

Comments

mcdwayne created an issue. See original summary.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 3042817-2.patch4.46 KB

Patch attached.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented

Note: There seems to be a Git issue with this repo that I don't know how to fix. But when cloning the repo and checking out the 8.x-1.x branch, it's not up to date with what's on Drupal Git (GitLab). It gives the following error: warning: refname '8.x-1.x' is ambiguous.. I had to do a hard reset to get the right content to create the patch.

That's also probably why the report above isn't in line with the patch I created. And the patch does not apply.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
StatusFileSize
new 3042817-4.patch17.3 KB

This patch will probably apply and pass, but shouldn't be used since it's not in sync with the repo... no idea how to fix this as a none maintainer.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs review » Needs work

All right, let's set this to needs work until the repository is fixed. I reached out to the Drupal Infra team to have a look at this as well. (hiding patch 4 as well).

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs work » Postponed

Blocked until this issue is resolved: #3048538: Fix Git repo (warning: refname '8.x-1.x' is ambiguous.)

jeqq’s picture

jeqq commented
Status: Postponed » Needs review
jeqq’s picture

jeqq commented
Status: Needs review » Needs work
shubhangi1995’s picture

shubhangi1995
Location GURGAON
commented
Assigned: Unassigned » shubhangi1995
shubhangi1995’s picture

shubhangi1995
Location GURGAON
commented
StatusFileSize
new 3042817--10.patch4.98 KB

replaced assertEqual and assertIdenticals

shubhangi1995’s picture

shubhangi1995
Location GURGAON
commented
Assigned: shubhangi1995 » Unassigned
Status: Needs work » Needs review
heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs review » Needs work

Let's combine #3121936: Drupal 9 readiness into here.

mrinalini9’s picture

mrinalini9 commented
Assigned: Unassigned » mrinalini9
mrinalini9’s picture

mrinalini9 commented
Assigned: mrinalini9 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3042817--14.patch5.38 KB
new interdiff-3042817-10-14.txt346 bytes

Updated patch as suggested in #12.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Looks okay to me.

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Status: Reviewed & tested by the community » Fixed

  • 2eb2aa6 committed on 8.x-1.x 
    Issue #3042817 by BramDriesen, DuaelFr, mrinalini9, shubhangi1995:...
duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented

Thank you all for your work here!

DuaelFr credited Shruthi Shetty M.

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented

Adding credit from #3186113: Add the 'core_version_requirement' key in info.yml

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.