Drupal 9 Deprecated Code Report

@mcdwayne, Please find the below-attached patch, & let me know if any further changes are required.

Thanks!

drupal-check (https://github.com/mglaman/drupal-check) is about https://pantheon.io/blog/your-module-ready-drupal-9-click-here-find-out

1. +++ b/tests/src/Functional/FieldPermissionsCommentTest.php
   @@ -113,7 +113,7 @@ class FieldPermissionsCommentTest extends FieldPermissionsTestBase {
   +    Drupal::service('entity_display.repository')->getFormDisplay($entity_type, $bundle, 'default')
   

   Drupal::service(...)
   Should be \Drupal::service(...)

2. +++ b/tests/src/Functional/FieldPermissionsCommentTest.php
   @@ -205,8 +205,8 @@ class FieldPermissionsCommentTest extends FieldPermissionsTestBase {
   +    $this->assertSession('Limit User comment subject');
   

   $this->assertSession() should not be used like that. See Drupal\FunctionalTests\AssertLegacyTrait for all alternatives.

   E.g. $this->assertText() should be $this->assertSession()->pageTextContains().

   $this->assertResponse() should be $this->assertSession()->statusCodeEquals()

   and so on.

@JeroenT, Please find the updated patch for the same, thanks for your inputs. Hope this works now.

1. +++ b/tests/src/Functional/FieldPermissionsCommentTest.php
   @@ -113,7 +113,7 @@ class FieldPermissionsCommentTest extends FieldPermissionsTestBase {
   +    EntityFormDisplay::load($entity_type, $bundle, 'default')
   

   EntityFormDisplay class should be imported.

2. +++ b/tests/src/Functional/FieldPermissionsCommentTest.php
   @@ -189,15 +189,15 @@ class FieldPermissionsCommentTest extends FieldPermissionsTestBase {
   +    $this->assertSession()->responseContains()($this->commentSubject);
   

   This line seems odd. Should be replaced with $this->assertSession()->responseContains($this->commentSubject);

I am working on it.

Here is the correct patch. Kindly review and merge.

Hi folks

I took the patch in comment #12, and solved to issues reported by drupal-check, but there two internal @deprecated issues that should be fixed or may be ignored.

------ ----------------------------------------------------------------------------------------------------------------------
  Line   src/Controller/FieldPermissionsController.php
 ------ ----------------------------------------------------------------------------------------------------------------------
  98     Call to deprecated method getList() of class Drupal\field_permissions\FieldPermissionsServiceInterface:
         This function will be removed before 8.x-1.0
  148    Call to deprecated method getPermissionsByRole() of class Drupal\field_permissions\FieldPermissionsServiceInterface:
         This function will be removed before 8.x-1.0
 ------ ----------------------------------------------------------------------------------------------------------------------

 ------ ------------------------------------------------------------------------------------------------
  Line   src/Plugin/FieldPermissionType/CustomAccess.php
 ------ ------------------------------------------------------------------------------------------------
  106    Call to deprecated method getList() of class Drupal\field_permissions\FieldPermissionsService:
         This function will be removed before 8.x-1.0
 ------ ------------------------------------------------------------------------------------------------

Please ignore the files attached in the previous comment

is this done and ready to be merged, and are we all squared away for D9 support after merging?

I believe there is also a composer.json change that should be made to add the Drupal 9 support badge to the module's main page, as explained here: https://www.drupal.org/project/auto_entitylabel/issues/3111526

EDIT: or perhaps the change needs to be made to the core_version_requirement field in the module's .info file. Here's an example from another project: https://www.drupal.org/files/issues/2020-03-12/3119389-d9-upgrade-2.patch

EDIT 2: my information about composer.yml and info.yml was incorrect, sorry. Apparently there is some switch the maintainer can flip to trigger the badge and mark the module as D9 compatible, but I don't know where that switch is since I am not a maintainer. Sorry.

@-enzo-, I applied patch field-permission-3042752-12.patch and I see no core deprecation warnings. However, I do still see the internal field_permissions warnings:

$ ./vendor/bin/drupal-check modules/field_permissions/
 24/24 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ---------------------------------------------------------------------------------------------------------------------- 
  Line   src/Controller/FieldPermissionsController.php                                                                         
 ------ ---------------------------------------------------------------------------------------------------------------------- 
  98     Call to deprecated method getList() of class Drupal\field_permissions\FieldPermissionsServiceInterface:               
         This function will be removed before 8.x-1.0                                                                          
  148    Call to deprecated method getPermissionsByRole() of class Drupal\field_permissions\FieldPermissionsServiceInterface:  
         This function will be removed before 8.x-1.0                                                                          
 ------ ---------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------ 
  Line   src/Plugin/FieldPermissionType/CustomAccess.php                                                 
 ------ ------------------------------------------------------------------------------------------------ 
  106    Call to deprecated method getList() of class Drupal\field_permissions\FieldPermissionsService:  
         This function will be removed before 8.x-1.0                                                    
 ------ ------------------------------------------------------------------------------------------------ 

 ------ ---------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Functional/FieldPermissionsTestBase.php                                                         
 ------ ---------------------------------------------------------------------------------------------------------- 
  136    Call to deprecated method getAllPermissions() of class Drupal\field_permissions\FieldPermissionsService:  
         This function will be removed before 8.x-1.0                                                              
 ------ ---------------------------------------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 4 errors

Seeing as this issue is about Drupal 9 compatibility, I think these internal deprecation are outside the scope of this issue, thus I am marking this as RTBC. Maintainers, should we open another issue about these internal deprecation warnings?

I don't see any further deprecations then what are fixed in this issue. I've added a D9 test pass, to see if it catches things we can't find via static test analysis.

However, this module still needs core_version_requirement: ^8 || ^9 to info.yml and (possibily) drupal/core: "^8 || ^9. For that, marking NW.

@heddn, can you provide that patch?

I'll try to get to that. But I learned a few more things since I posted that comment yesterday and
core_version_requirement: ^8 || ^9 to info.yml is all that is needed.

@heddn I have attached 3042752-13.patch, which includes core_version_requirement change. Please review.

That looks good to me. Thanks for throwing up the patch. Here's an interdiff for anyone else between #16and #25.

thanks @heddn

With D9 releasing today, any chance for a commit and new tagged release? Maybe a mention in the Drupal 9 support project field what the plans are for supporting D9?

+1

Tests are still failing.

+++ b/tests/src/Functional/FieldPermissionsUserTest.php
@@ -73,15 +73,15 @@ class FieldPermissionsUserTest extends FieldPermissionsTestBase {
+    EntityFormDisplay::load('user', 'user', 'default')
...
+    EntityFormDisplay::load('user', 'user', 'register')

EntityFormDisplay class should be imported.

Sorry, my fault, I am having issues running tests on my machine

attaching 3042752-13.patch to address #30. I'm not sure if the other test failures are related.

sorry @JeroenT, thanks for cleaning up my mess *facepalm*

I just applied your patch 3042752-32.patch cleanly and it resolved the D9 deprecations. Again, I;m having trouble running test on my machine, but your testbot results obviously passed. So, if you aren't still working and 3042752-32.patch is your final patch, feel free to mark this RTBC.

@xeM8VfDh, np.

Marking the issue RTBC.

Thanks all for working on this. Fixed!