drupal-check results on commit hash: source : [git] https://git.drupal.org/project/session_limit 683bfd137708adf520f02767dc5b9b3d276084c1
source : http://cgit.drupalcode.org/session_limit 


 

 ------ --------------------------------------------------- 
  Line   src/Services/SessionLimit.php                      
 ------ --------------------------------------------------- 
  249    Call to deprecated function drupal_set_message().  
  250    Call to deprecated method url() of class Drupal.   
  351    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------- 
  Line   tests/SessionLimitBaseTestCase.php                                                 
 ------ ----------------------------------------------------------------------------------- 
         Class Drupal\session_limit\SessionLimitBaseTestCase was not found while trying to  
         analyse it - autoloading is probably not configured properly.                      
 ------ ----------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------- 
  Line   tests/SessionLimitLogoutTestCase.php                                              
 ------ ---------------------------------------------------------------------------------- 
         Class Drupal\session_limit\SessionLimitLogoutTestCase was not found while trying  
         to analyse it - autoloading is probably not configured properly.                  
 ------ ---------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------- 
  Line   tests/SessionLimitPreventTestCase.php                                              
 ------ ----------------------------------------------------------------------------------- 
         Class Drupal\session_limit\SessionLimitPreventTestCase was not found while trying  
         to analyse it - autoloading is probably not configured properly.                   
 ------ ----------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------- 
  Line   tests/SessionLimitSessionTestCase.php                                              
 ------ ----------------------------------------------------------------------------------- 
         Class Drupal\session_limit\SessionLimitSessionTestCase was not found while trying  
         to analyse it - autoloading is probably not configured properly.                   
 ------ ----------------------------------------------------------------------------------- 

 [ERROR] Found 7 errors
CommentFileSizeAuthor
#6 drupal_9_deprecated_code-3042747-6.patch4.19 KBnikolas.tatianenko
#3 drupal_9_deprecated_code-3042747-3.patch32.13 KBsergiu stici

Comments

mcdwayne created an issue. See original summary.

mcdwayne’s picture

mcdwayne commented
Issue summary: View changes

fixed formatting issue

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
StatusFileSize
new drupal_9_deprecated_code-3042747-3.patch32.13 KB

Here is the patch, please review.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Drupal 9 Deprecated Code Report » Drupal 9 Deprecated Code Report for Session Limit module
sutharsan’s picture

sutharsan commented
Status: Needs review » Needs work 
+++ b/src/Services/SessionLimit.php
@@ -281,10 +293,10 @@ class SessionLimit implements EventSubscriberInterface {
-    $limit = $this->database->query("SELECT COUNT(DISTINCT(sid)) - :max_sessions FROM {sessions} WHERE uid = :uid", array(
+    $limit = $this->database->query("SELECT COUNT(DISTINCT(sid)) - :max_sessions FROM {sessions} WHERE uid = :uid", [
       ':max_sessions' => $event->getUserMaxSessions(),

Let's not mix deprecation errors with code style fixes. This makes the patch harder to review.

nikolas.tatianenko’s picture

nikolas.tatianenko commented
Status: Needs work » Needs review
Issue tags: +Drupal 9 porting day, +epam-contrib
StatusFileSize
new drupal_9_deprecated_code-3042747-6.patch4.19 KB

WIthout code styles improvements

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: -Drupal 9 porting day +Drupal 9 porting weekend

Fix tag to be event-appropriate.

sutharsan’s picture

sutharsan commented
Status: Needs review » Reviewed & tested by the community

Path looks good.

suzymasri’s picture

suzymasri
Location Greece
commented

Patch #6 LGTM.

As for the remaining tests errors, #3145938: Convert tests to PHPUnit was created to convert tests to PHPUnit.

suzymasri’s picture

suzymasri
Location Greece
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.