Closed (fixed)
Project:
Drupal core
Version:
8.7.x-dev
Component:
taxonomy.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
23 Mar 2019 at 18:04 UTC
Updated:
16 Apr 2019 at 12:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
jian he commentedComment #3
jian he commentedFix assertEqual
Comment #4
claudiu.cristea@jian he, thank you for the conversion.
Docblocks should be replaced with
{@inheritdoc}.s/Term/TermInterface
Missed docblock. Should
{@inheritdoc}Missing documentation block.
Uses Drupal::l(), which is deprecated. Should be updated.
Comment #5
claudiu.cristeas/public/protected
Comment #6
jian he commented@claudiu.cristea, thanks for the review.
This patch fixed all #4 and #5.
Comment #8
claudiu.cristeaYes, this was a bad idea. I didn't realize we're extending from ViewsKernelTestBase. Sorry.
Shouldn't this be $expected->toString()?
Comment #9
jian he commented#8.1 oh, I does not realized that ViewsKernelTestBase use public $module.
#8.2 does not need toString(). Both $expected and $actual are array, and the assertEquals() can compare the two array.
Comment #11
jian he commentedah, #8.2 is right
Comment #12
claudiu.cristeaThank you.
Comment #13
alexpottCommitted and pushed 603f0d4cc7 to 8.8.x and 88ecbd912d to 8.7.x. Thanks!
As a test only change backported to 8.7.x - I discussed backporting test-only changes with @catch (as a release manager).