Drupal 9 Deprecated Code Report [#3042622]

Problem/Motivation

drupal-check on version:
b100cdf4bee604e6973430579fee4028e4a30d88





 ------ ----------------------------------------------------------------------------------------- 
  Line   file_mdm_exif/tests/src/Kernel/FileMetadataExifTest.php                                  
 ------ ----------------------------------------------------------------------------------------- 
  134    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  137    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  146    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  149    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  156    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  160    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  179    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  181    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  182    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  185    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  187    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  189    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  194    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  195    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  199    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  202    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  209    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  210    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  212    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  215    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  222    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  223    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  225    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  228    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  235    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  236    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  238    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  241    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  260    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  262    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  264    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  271    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  272    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  274    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  276    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  278    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  279    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  280    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  281    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  286    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  291    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  294    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  295    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  296    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  297    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  298    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  299    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  300    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  301    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  308    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  309    Call to deprecated method assertIdentical() of class Drupal\KernelTests\KernelTestBase.  
  313    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  314    Call to deprecated method assertIdentical() of class Drupal\KernelTests\KernelTestBase.  
  330    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  331    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  334    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  336    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  337    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  339    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  346    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  347    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
 ------ ----------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------- 
  Line   file_mdm_font/tests/src/Kernel/FileMetadataFontTest.php                                  
 ------ ----------------------------------------------------------------------------------------- 
  73     Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  74     Call to deprecated method assertIdentical() of class Drupal\KernelTests\KernelTestBase.  
  76     Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  111    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
 ------ ----------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------- 
  Line   src/Plugin/FileMetadata/FileMetadataPluginBase.php  
 ------ ---------------------------------------------------- 
  345    Call to deprecated function file_uri_scheme().      
 ------ ---------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------- 
  Line   tests/src/Kernel/FileMetadataManagerTest.php                                             
 ------ ----------------------------------------------------------------------------------------- 
  115    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  118    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  126    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  134    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  147    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  150    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  156    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  159    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  161    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  164    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  228    Call to deprecated method assertIdentical() of class Drupal\KernelTests\KernelTestBase.  
  233    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  246    Call to deprecated method assertIdentical() of class Drupal\KernelTests\KernelTestBase.  
  249    Call to deprecated method assertIdentical() of class Drupal\KernelTests\KernelTestBase.  
  251    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  254    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  276    Call to deprecated method assertIdentical() of class Drupal\KernelTests\KernelTestBase.  
  280    Call to deprecated method assertIdentical() of class Drupal\KernelTests\KernelTestBase.  
  281    Call to deprecated method assertIdentical() of class Drupal\KernelTests\KernelTestBase.  
  282    Call to deprecated method assertIdentical() of class Drupal\KernelTests\KernelTestBase.  
  287    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  328    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  331    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  340    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  343    Call to deprecated method assertIdentical() of class Drupal\KernelTests\KernelTestBase.  
  381    Call to deprecated method assertIdentical() of class Drupal\KernelTests\KernelTestBase.  
  383    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  386    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  392    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
  395    Call to deprecated method assertIdentical() of class Drupal\KernelTests\KernelTestBase.  
  413    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase.      
 ------ ----------------------------------------------------------------------------------------- 

 [ERROR] Found 97 errors

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comment	File	Size	Author
#2	drupal_9_deprecated_code-3042622-2.patch	29.89 KB	sergiu stici

Comments

Comment #1

23 March 2019 at 17:31

josephdpurcell created an issue. See original summary.

Comment #2

sergiu stici commented 16 April 2019 at 09:30

Status:

Active

» Needs review

Status	File	Size
new	drupal_9_deprecated_code-3042622-2.patch	29.89 KB

Here is the patch, please review.

Comment #3

16 April 2019 at 14:22

mondrake committed 325f50f on 8.x-1.x authored by Sergiu Stici

Issue #3042622 by Sergiu Stici: Drupal 9 Deprecated Code Report

Comment #4

mondrake

🇮🇹

commented 16 April 2019 at 14:26

Status:

Needs review

» Fixed

Thank you, committed, with the exception of the following hunk:

+++ b/file_mdm_font/tests/src/Kernel/FileMetadataFontTest.php
@@ -108,7 +108,7 @@ class FileMetadataFontTest extends FileMetadataManagerTestBase {
diff --git a/src/Plugin/FileMetadata/FileMetadataPluginBase.php b/src/Plugin/FileMetadata/FileMetadataPluginBase.php

diff --git a/src/Plugin/FileMetadata/FileMetadataPluginBase.php b/src/Plugin/FileMetadata/FileMetadataPluginBase.php
index fd2a0dd..ce76d70 100644

index fd2a0dd..ce76d70 100644
--- a/src/Plugin/FileMetadata/FileMetadataPluginBase.php

--- a/src/Plugin/FileMetadata/FileMetadataPluginBase.php
+++ b/src/Plugin/FileMetadata/FileMetadataPluginBase.php

+++ b/src/Plugin/FileMetadata/FileMetadataPluginBase.php
+++ b/src/Plugin/FileMetadata/FileMetadataPluginBase.php
@@ -6,6 +6,7 @@ use Drupal\Core\Cache\Cache;

@@ -6,6 +6,7 @@ use Drupal\Core\Cache\Cache;
 use Drupal\Core\Cache\CacheBackendInterface;
 use Drupal\Core\Config\ConfigFactoryInterface;
 use Drupal\Core\Form\FormStateInterface;
+use \Drupal\Core\File\FileSystem;
 use Drupal\Core\Plugin\PluginBase;
 use Drupal\file_mdm\FileMetadataException;
 use Drupal\file_mdm\FileMetadataInterface;
@@ -342,7 +343,7 @@ abstract class FileMetadataPluginBase extends PluginBase implements FileMetadata

@@ -342,7 +343,7 @@ abstract class FileMetadataPluginBase extends PluginBase implements FileMetadata
     }
 
     // URIs without valid scheme, and temporary:// URIs are not cached.
-    if (!file_valid_uri($this->getUri()) || file_uri_scheme($this->getUri()) === 'temporary') {
+    if (!file_valid_uri($this->getUri()) || FileSystem::uriScheme($this->getUri()) === 'temporary') {
       return FALSE;
     }

Here we shoud inject the service in the constructor, adding it in the create method. Besides, it's better wait for a new branch to do so.

Let's have a specific follow up for this.

Comment #5

30 April 2019 at 14:29

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Drupal 9 Deprecated Code Report

Problem/Motivation

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Child issues

News items

Our community

Documentation

Drupal code base

Governance of community