Closed (fixed)
Project:
Paragraphs
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
23 Mar 2019 at 16:44 UTC
Updated:
20 Jan 2020 at 08:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
sergiu stici commentedI created the patch, please review.
Comment #4
sergiu stici commentedCorrect the codesniffer and any mistakes.
Comment #6
joelpittetTagging for DrupalCon Seattle Friday contribution sprint.
See https://github.com/mglaman/drupal-check/wiki/Drupal-9-Readiness
Comment #7
tatarbjComment #8
alex.bukach commentedComment #9
alex.bukach commentedComment #10
alex.bukach commentedFixed drupal-check issues for current dev except for an optional one caused by optional support of Libraries API.
Comment #12
alex.bukach commentedComment #13
berdir> Error: Call to a member function setComponent() on null
Ignore entity_get_display()/entity_get_form_display(). 8.7 has a proper replacement but we don't depend on that yet. See https://www.drupal.org/node/2835616.
Comment #14
alex.bukach commentedThanks @Berdir!
Comment #15
berdirRelated/child issues:
* #3073631: [D8.8] Replace deprecated entity_get_form_display and entity_get_display
* #3099355: Requirement of core version should be higher in composer.json
* #3083331: Removing deprecated method entityManager.
* #3095644: Add defaultTheme in tests extending BrowserTestBase.
There is a separate issue for that, so remove all entity manager changes.
As we have a separate issue for that, lets remove all entity_get_form/view_display() changes.
Comment #16
berdirAlso, I did run all tests locally to see the deprecation messages, this is what I got:
This is \Drupal\paragraphs\Plugin\EntityReferenceSelection\ParagraphSelection, we can remove the constructor and property because the parent now defines it.
This is likely covered with the patch here, but we'll need to make sure that we've updated all classes. Some are likely also from our dependencies.
That's the related issue mentioned above.
That's the entity.manager issue also again some might be from other modules.
THis is likely in entity_reference_revisions_field_views_data() and not paragraphs.
This requires 8.8, so we could possibly deal with it in the entity_get_display issue.
This is a tricky one. We could depend on https://www.drupal.org/project/jquery_ui_tabs for that, but maybe there's a better option? Probably better to open a separate issue.
(some skipped as they are addressed here or are from other modules)
This needs to be fixed here.
This too if it's not already.
Comment #17
chr.fritschSo, this is a fresh start, after all the other issues were committed.
Comment #18
berdirthat we didn't deprecate file_build_uri() was kind of an oversight, I expect it will go sooner or later. We don't really need this to be dynamic, lets just hardcode public://
this assert/comment doesn't really make sense then anymore.
Comment #19
chr.fritschFixing the tests and the comments from @Berdir
Comment #20
berdirLets implement DependentPluginInterface too. I'm not sure if actually handle this correctly yet, but these are plugins with configuration that are stored on config entities, so they can have dependencies and should expose them.
Comment #21
andreyjan commentedAdded DependentPluginInterface interface.
Comment #22
berdirComment #23
berdirCommitted this and made #3055618: Remove own sortablejs library, remove remaining 8.8 deprecations the 8.8 follow-up.
Comment #25
berdir