Problem/Motivation

Identified in #3002608: Remove contextual links not related to layout administration inside layout builder blocks

Many of Layout Builder's functional and functional Javascript include these no-longer-valid lines:

    // @todo The Layout Builder UI relies on local tasks; fix in
    //   https://www.drupal.org/project/drupal/issues/2917777.
    $this->drupalPlaceBlock('local_tasks_block');

They are no longer valid because:

  • The UI does not rely on local tasks
  • The scope of the issue mentioned in the @todo

Proposed resolution

If a test does not include any clicking on local task links, just remove the three lines mentioned above.

For tests that include clicking on local task links where the same outcome can be accomplished by navigating directly, change these tests to navigate directly to their destination instead of clicking local tasks, then remove those three lines..

If there's good reason to keep local tasks in a test, then just remove the @todo, as it is no longer relevant.

Remaining tasks

Refactor tests, review, commit.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bnjmnm created an issue. See original summary.

bnjmnm’s picture

Issue summary: View changes
Status: Active » Needs review
FileSize
11.7 KB
bnjmnm’s picture

Updated to take care of two recently committed issues that also needed this change.

tim.plunkett’s picture

phenaproxima’s picture

Status: Needs review » Reviewed & tested by the community

Looks okay to me.

  • xjm committed e9c89de on 8.8.x
    Issue #3042089 by bnjmnm: Update Layout Builder functional javascript...

  • xjm committed 9c5bdbb on 8.7.x
    Issue #3042089 by bnjmnm: Update Layout Builder functional javascript...
xjm’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8.8.x and cherry-picked to 8.7.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.