Problem/Motivation
Identified in #3002608: Remove contextual links not related to layout administration inside layout builder blocks
Many of Layout Builder's functional and functional Javascript include these no-longer-valid lines:
// @todo The Layout Builder UI relies on local tasks; fix in
// https://www.drupal.org/project/drupal/issues/2917777.
$this->drupalPlaceBlock('local_tasks_block');
They are no longer valid because:
- The UI does not rely on local tasks
- The scope of the issue mentioned in the
@todo
Proposed resolution
If a test does not include any clicking on local task links, just remove the three lines mentioned above.
For tests that include clicking on local task links where the same outcome can be accomplished by navigating directly, change these tests to navigate directly to their destination instead of clicking local tasks, then remove those three lines..
If there's good reason to keep local tasks in a test, then just remove the @todo, as it is no longer relevant.
Remaining tasks
Refactor tests, review, commit.
User interface changes
N/A
API changes
N/A
Data model changes
N/A
Release notes snippet
N/A
Comment | File | Size | Author |
---|---|---|---|
#3 | 3042089-3.patch | 13.39 KB | bnjmnm |
#3 | interdiff_2-3.txt | 1.7 KB | bnjmnm |
#2 | 3042089-2.patch | 11.7 KB | bnjmnm |
Comments
Comment #2
bnjmnmComment #3
bnjmnmUpdated to take care of two recently committed issues that also needed this change.
Comment #4
tim.plunkettComment #5
phenaproximaLooks okay to me.
Comment #8
xjmCommitted to 8.8.x and cherry-picked to 8.7.x. Thanks!