Problem/Motivation
When a paragraph is created using a format that another role does not have access to, an user with the role without the permission will only be able to save when the Paragraph is not collapsed. If collapsed the validation will fail and the user will get an error pointing to the weight of the paragraph.
Proposed resolution
Fix it.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | validation_error-3041808-7-interdiff.txt | 661 bytes | berdir |
| #7 | validation_error-3041808-7.patch | 4.93 KB | berdir |
| #5 | validation_error-3041808-5.patch | 4.95 KB | berdir |
| #4 | validation_error-3041808-4.patch | 8.9 KB | berdir |
| #2 | validation_error-3041808-2.patch | 2.62 KB | johnchque |
Comments
Comment #2
johnchqueFailing test.
Comment #4
berdirThanks. As a quickfix, just filtering out validation errors on .format, as a bonus, I also improved the message we display, so it says a bit more, including the property path (which is very technical, but better than nothing).
Comment #5
berdirHm, PhpStorm did a bunch of unrelated cleanup there, removed again.
Comment #7
berdirOops.
Comment #9
berdirComment #10
miro_dietikerYeah this looks cool.
However there are multiple (not yet covered) special cases related to this problem and we should cover them in follow-ups.
Reminder: We discussed that we should force-expand a Paragraph with validation error as the user needs to edit and fix the situation anyway to save. We need to be careful to check access for such an expansion and skip the validation for Paragraphs without access.