First of all: thank you for the new 6.x-1.6 release.

When I read the 'Removed duplicate title attribute in abbr links.' comment in the release notes I already guessed what happened ;-)

The title attribute in the A element, when using the ABBR element, wasn't a duplicate attribute. Even though the surrounding ABBR element already has one, you'll need the extra one in the A element because IE6 will ignore the ABBR element completely, including the TITLE attribute. For IE6 the one in the A element will be used. The one in the ABBR element is still required because that's the one that will be used by screen readers.

CommentFileSizeAuthor
#1 title.patch1.2 KBForage

Comments

Forage’s picture

Forage commented
Assigned: Unassigned » Forage
Status: Active » Needs review
StatusFileSize
new title.patch1.2 KB

Here's the patch fixing the issue.

Forage’s picture

Forage commented

P.s. I noticed you removed check_plain() from all title attributes. You forgot one which is removed in this patch as well. Is check_plain() not required any more now that you're using filter_xss()?

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Status: Needs review » Fixed

Yes, filter_xss should take care of it, without producing those pesky HTML entities.

Thanks for the patch and the explanation. Committed on both branches.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.