Problem/Motivation

ArgumentStringTest makes no HTTP requests but is a functional test

Proposed resolution

Convert ArgumentStringTest into a Kernel test

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

N/A

CommentFileSizeAuthor
#2 3041770-2.patch2.55 KBclaudiu.cristea
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

claudiu.cristea created an issue. See original summary.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon commented
Status: Active » Needs review
FileSize
3041770-2.patch2.55 KB

This patch decreases. locally, the test run from 8.5 to 3 seconds.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude at ezCompany commented
Status: Needs review » Reviewed & tested by the community

Nice, compared before and after and no loss of coverage that I can see.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 8.8.x-dev » 8.7.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 5235ea9ab5 to 8.8.x and d16a64e11f to 8.7.x. Thanks!

As a test only change backported to 8.7.x - I discussed backporting test-only changes with @catch (as a release manager).

  • alexpott committed 5235ea9 on 8.8.x 
    Issue #3041770 by claudiu.cristea: Convert ArgumentStringTest into a...

  • alexpott committed d16a64e on 8.7.x 
    Issue #3041770 by claudiu.cristea: Convert ArgumentStringTest into a...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.