Problem/Motivation

FieldGroupRowsTest make no HTTP requests but is a functional test.

Proposed resolution

Convert FieldGroupRowsTest into a Kernel test

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

N/A

CommentFileSizeAuthor
#2 3041765-2.patch7.05 KBclaudiu.cristea
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

claudiu.cristea created an issue. See original summary.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon commented
Status: Active » Needs review
FileSize
3041765-2.patch7.05 KB

This patch decreases, locally, the test run from 15.5 to 3.5 seconds.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude at ezCompany commented
Status: Needs review » Reviewed & tested by the community

Hard to read diff, did a line-by-line comparison using FileMerge and everything checks out. Nice one.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 8.8.x-dev » 8.7.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 97f5efc2f1 to 8.8.x and f4ede890a9 to 8.7.x. Thanks!

As a test only change backported to 8.7.x - I discussed backporting test-only changes with @catch (as a release manager).

  • alexpott committed 97f5efc on 8.8.x 
    Issue #3041765 by claudiu.cristea: Convert FieldGroupRowsTest into a...

  • alexpott committed f4ede89 on 8.7.x 
    Issue #3041765 by claudiu.cristea: Convert FieldGroupRowsTest into a...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.