Remove EntityDisplaySectionsTest in favor of a full suite of REST/HAL tests

1. +++ b/core/modules/layout_builder/tests/src/Functional/Hal/LayoutBuilderEntityViewDisplayHalJsonAnonTest.php
   @@ -0,0 +1,31 @@
   +  public static $modules = ['layout_builder', 'hal'];
   
   +++ b/core/modules/layout_builder/tests/src/Functional/Hal/LayoutBuilderEntityViewDisplayHalJsonBasicAuthTest.php
   @@ -0,0 +1,26 @@
   +  public static $modules = ['layout_builder', 'basic_auth'];
   
   +++ b/core/modules/layout_builder/tests/src/Functional/Hal/LayoutBuilderEntityViewDisplayHalJsonCookieTest.php
   @@ -0,0 +1,25 @@
   +  public static $modules = ['layout_builder'];
   
   +++ b/core/modules/layout_builder/tests/src/Functional/Rest/LayoutBuilderEntityViewDisplayJsonAnonTest.php
   @@ -0,0 +1,30 @@
   +  public static $modules = ['layout_builder'];
   
   +++ b/core/modules/layout_builder/tests/src/Functional/Rest/LayoutBuilderEntityViewDisplayResourceTestBase.php
   @@ -0,0 +1,45 @@
   +abstract class LayoutBuilderEntityViewDisplayResourceTestBase extends EntityViewDisplayResourceTestBase {
   
   +++ b/core/modules/layout_builder/tests/src/Functional/Rest/LayoutBuilderEntityViewDisplayXmlAnonTest.php
   @@ -0,0 +1,32 @@
   +  public static $modules = ['layout_builder'];
   

   🔍🤔 Übernit: you can omit 'layout_builder' from these and just set this in the base test class :)

2. +++ b/core/modules/layout_builder/tests/src/Functional/Rest/LayoutBuilderEntityViewDisplayResourceTestBase.php
   @@ -0,0 +1,45 @@
   +  protected static $resourceConfigId = 'entity.entity_view_display';
   

   🤔 AFAICT this can be removed?

3. +++ b/core/modules/layout_builder/tests/src/Functional/Rest/LayoutBuilderEntityViewDisplayResourceTestBase.php
   @@ -0,0 +1,45 @@
   +  protected function createEntity() {
   +    /** @var \Drupal\layout_builder\Entity\LayoutBuilderEntityViewDisplay $entity */
   +    $entity = parent::createEntity();
   +    $entity
   +      ->enableLayoutBuilder()
   +      ->setOverridable()
   +      ->save();
   +    return $entity;
   +  }
   +
   +  /**
   +   * {@inheritdoc}
   +   */
   +  protected function getExpectedNormalizedEntity() {
   +    $expected = parent::getExpectedNormalizedEntity();
   +    array_unshift($expected['dependencies']['module'], 'layout_builder');
   +    $expected['hidden'][OverridesSectionStorage::FIELD_NAME] = TRUE;
   +    $expected['third_party_settings']['layout_builder'] = [
   +      'enabled' => TRUE,
   +      'allow_custom' => TRUE,
   +    ];
   +    return $expected;
   +  }
   

   👍 Perfect!

Addressed #3.

As far as I'm concerned, this is then RTBC. @tim.plunkett, are you +1 to the changes in this interdiff?

Alright, RTBC it is then 🥳

+++ /dev/null
@@ -1,61 +0,0 @@
-    // Ensure the sections are not present in the serialized data, but other
-    // Layout Builder data is.
-    $this->assertArrayHasKey('layout_builder', $response_data['third_party_settings']);
-    $this->assertArrayNotHasKey('sections', $response_data['third_party_settings']['layout_builder']);
-    $this->assertEquals(['enabled' => TRUE, 'allow_custom' => TRUE], $response_data['third_party_settings']['layout_builder']);

+++ b/core/modules/layout_builder/tests/src/Functional/Rest/LayoutBuilderEntityViewDisplayResourceTestBase.php
@@ -0,0 +1,45 @@
+  protected function createEntity() {
+    /** @var \Drupal\layout_builder\Entity\LayoutBuilderEntityViewDisplay $entity */
+    $entity = parent::createEntity();
+    $entity
+      ->enableLayoutBuilder()
+      ->setOverridable()
+      ->save();
+    return $entity;
+  }
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function getExpectedNormalizedEntity() {
+    $expected = parent::getExpectedNormalizedEntity();
+    array_unshift($expected['dependencies']['module'], 'layout_builder');
+    $expected['hidden'][OverridesSectionStorage::FIELD_NAME] = TRUE;
+    $expected['third_party_settings']['layout_builder'] = [
+      'enabled' => TRUE,
+      'allow_custom' => TRUE,

For core committers: these assertions have essentially been moved and now run in more scenarios.

Ah yes, thanks! I had forgotten to call that out in my review even though I noticed it. My bad. Thanks for fixing it!

Guessing this is about the most literal stable blocker we could have.

+++ /dev/null
@@ -1,61 +0,0 @@
-    // Assert the display has 1 section.
-    $this->assertCount(1, $display->getThirdPartySetting('layout_builder', 'sections'));

+++ b/core/modules/layout_builder/tests/src/Functional/Rest/LayoutBuilderEntityViewDisplayResourceTestBase.php
@@ -0,0 +1,45 @@
+  protected function createEntity() {
+    /** @var \Drupal\layout_builder\Entity\LayoutBuilderEntityViewDisplay $entity */
+    $entity = parent::createEntity();
+    $entity
+      ->enableLayoutBuilder()
+      ->setOverridable()
+      ->save();
+    return $entity;
+  }
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function getExpectedNormalizedEntity() {
+    $expected = parent::getExpectedNormalizedEntity();
+    array_unshift($expected['dependencies']['module'], 'layout_builder');
+    $expected['hidden'][OverridesSectionStorage::FIELD_NAME] = TRUE;
+    $expected['third_party_settings']['layout_builder'] = [
+      'enabled' => TRUE,
+      'allow_custom' => TRUE,
+    ];
+    return $expected;
+  }

One thing we're losing here is assertions about the expected format of the entity when not served over REST (basically, that the layout has one section which is not served over REST because we've excluded section data from the response). So the test could have a false positive from a layout with no sections... and actually, didn't we change the default behavior to no longer add a section automatically, so it'd be easy to get in a situation that has that false positive?

That works. This is ready for commit after the freeze is over.

Committed and pushed to 8.8.x. We'll backport to 8.7.x in a bit.

Thanks!