After enabled the module and rename user path (only user path), it works perfectly when browsing with new path.
However, when browsing /user, I'm getting the below error:-

The website encountered an unexpected error. Please try again later.</br></br><em class="placeholder">InvalidArgumentException</em>: Source path  has to start with a slash. in <em class="placeholder">Drupal\Core\Path\AliasManager-&gt;getAliasByPath()</em> (line <em class="placeholder">186</em> of <em class="placeholder">core/lib/Drupal/Core/Path/AliasManager.php</em>). <pre class="backtrace">Drupal\system\Plugin\Condition\RequestPath-&gt;evaluate() (Line: 74)
Drupal\Core\Condition\ConditionManager-&gt;execute(Object) (Line: 84)
Drupal\Core\Condition\ConditionPluginBase-&gt;execute() (Line: 26)
Drupal\block_visibility_groups\GroupEvaluator-&gt;resolveConditions(Object, &#039;and&#039;) (Line: 65)
Drupal\block_visibility_groups\GroupEvaluator-&gt;evaluateGroup(Object) (Line: 67)
Drupal\block_visibility_groups\Plugin\Condition\ConditionGroup-&gt;evaluate() (Line: 74)
Drupal\Core\Condition\ConditionManager-&gt;execute(Object) (Line: 84)
Drupal\Core\Condition\ConditionPluginBase-&gt;execute() (Line: 26)
Drupal\block\BlockAccessControlHandler-&gt;resolveConditions(Array, &#039;and&#039;) (Line: 116)
Drupal\block\BlockAccessControlHandler-&gt;checkAccess(Object, &#039;view&#039;, Object) (Line: 105)
Drupal\Core\Entity\EntityAccessControlHandler-&gt;access(Object, &#039;view&#039;, Object, 1) (Line: 365)
Drupal\Core\Entity\Entity-&gt;access(&#039;view&#039;, NULL, 1) (Line: 56)
Drupal\block\BlockRepository-&gt;getVisibleBlocksPerRegion(Array) (Line: 137)
Drupal\block\Plugin\DisplayVariant\BlockPageVariant-&gt;build() (Line: 259)
Drupal\Core\Render\MainContent\HtmlRenderer-&gt;prepare(Array, Object, Object) (Line: 117)
Drupal\Core\Render\MainContent\HtmlRenderer-&gt;renderResponse(Array, Object, Object) (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber-&gt;onViewRenderArray(Object, &#039;kernel.view&#039;, Object)
call_user_func(Array, Object, &#039;kernel.view&#039;, Object) (Line: 111)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher-&gt;dispatch(&#039;kernel.view&#039;, Object) (Line: 156)
Symfony\Component\HttpKernel\HttpKernel-&gt;handleRaw(Object, 2) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel-&gt;handle(Object, 2, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session-&gt;handle(Object, 2, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle-&gt;handle(Object, 2, 1) (Line: 99)
Drupal\page_cache\StackMiddleware\PageCache-&gt;pass(Object, 2, 1) (Line: 78)
Drupal\page_cache\StackMiddleware\PageCache-&gt;handle(Object, 2, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware-&gt;handle(Object, 2, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware-&gt;handle(Object, 2, 1) (Line: 23)
Stack\StackedHttpKernel-&gt;handle(Object, 2) (Line: 166)
Drupal\Core\EventSubscriber\DefaultExceptionHtmlSubscriber-&gt;makeSubrequest(Object, &#039;/node/119&#039;, 404) (Line: 119)
Drupal\Core\EventSubscriber\CustomPageExceptionHtmlSubscriber-&gt;makeSubrequestToCustomPath(Object, &#039;/node/119&#039;, 404) (Line: 81)
Drupal\Core\EventSubscriber\CustomPageExceptionHtmlSubscriber-&gt;on404(Object) (Line: 109)
Drupal\Core\EventSubscriber\HttpExceptionSubscriberBase-&gt;onException(Object, &#039;kernel.exception&#039;, Object)
call_user_func(Array, Object, &#039;kernel.exception&#039;, Object) (Line: 111)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher-&gt;dispatch(&#039;kernel.exception&#039;, Object) (Line: 228)
Symfony\Component\HttpKernel\HttpKernel-&gt;handleException(Object, Object, 1) (Line: 79)
Symfony\Component\HttpKernel\HttpKernel-&gt;handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session-&gt;handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle-&gt;handle(Object, 1, 1) (Line: 99)
Drupal\page_cache\StackMiddleware\PageCache-&gt;pass(Object, 1, 1) (Line: 78)
Drupal\page_cache\StackMiddleware\PageCache-&gt;handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware-&gt;handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware-&gt;handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel-&gt;handle(Object, 1, 1) (Line: 693)
Drupal\Core\DrupalKernel-&gt;handle(Object) (Line: 19)
</pre>

We should be getting 404 instead of the above error right?
FYI, caches cleared. Drupal version 8.6.9

CommentFileSizeAuthor
#8 rename_admin_paths-RenameProcessor-3040984-8.patch1.25 KBguncha25
#6 rename_admin_paths-RenameProcessor-3040984-6.patch1.28 KBhunchang
#5 rename_admin_paths-RenameProcessor-3040984-5.patch10.67 KBhunchang
#3 rename_admin_paths-RenameProcessor-3040984-3.patch1.33 KBhunchang

Comments

hunchang created an issue. See original summary.

hunchang’s picture

hunchang commented

On top of the above, when browsing front page, I'm getting the below:

Notice: Uninitialized string offset: 0 in Drupal\Core\Path\AliasManager->getAliasByPath() (line 185 of core\lib\Drupal\Core\Path\AliasManager.php).
Drupal\Core\Path\AliasManager->getAliasByPath('') (Line: 151)
Drupal\system\Plugin\Condition\RequestPath->evaluate() (Line: 74)
Drupal\Core\Condition\ConditionManager->execute(Object) (Line: 84)
Drupal\Core\Condition\ConditionPluginBase->execute() (Line: 26)
Drupal\block_visibility_groups\GroupEvaluator->resolveConditions(Object, 'and') (Line: 65)
Drupal\block_visibility_groups\GroupEvaluator->evaluateGroup(Object) (Line: 67)
Drupal\block_visibility_groups\Plugin\Condition\ConditionGroup->evaluate() (Line: 74)
Drupal\Core\Condition\ConditionManager->execute(Object) (Line: 84)
Drupal\Core\Condition\ConditionPluginBase->execute() (Line: 26)
Drupal\block\BlockAccessControlHandler->resolveConditions(Array, 'and') (Line: 116)
Drupal\block\BlockAccessControlHandler->checkAccess(Object, 'view', Object) (Line: 105)
Drupal\Core\Entity\EntityAccessControlHandler->access(Object, 'view', Object, 1) (Line: 365)
Drupal\Core\Entity\Entity->access('view', NULL, 1) (Line: 56)
Drupal\block\BlockRepository->getVisibleBlocksPerRegion(Array) (Line: 137)
Drupal\block\Plugin\DisplayVariant\BlockPageVariant->build() (Line: 259)
Drupal\Core\Render\MainContent\HtmlRenderer->prepare(Array, Object, Object) (Line: 117)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object, Object) (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object, 'kernel.view', Object)
call_user_func(Array, Object, 'kernel.view', Object) (Line: 111)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('kernel.view', Object) (Line: 156)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 2) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 2, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 2, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 2, 1) (Line: 99)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 2, 1) (Line: 78)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 2, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 2, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 2, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 2) (Line: 166)
Drupal\Core\EventSubscriber\DefaultExceptionHtmlSubscriber->makeSubrequest(Object, '/node/119', 404) (Line: 119)
Drupal\Core\EventSubscriber\CustomPageExceptionHtmlSubscriber->makeSubrequestToCustomPath(Object, '/node/119', 404) (Line: 81)
Drupal\Core\EventSubscriber\CustomPageExceptionHtmlSubscriber->on404(Object) (Line: 109)
Drupal\Core\EventSubscriber\HttpExceptionSubscriberBase->onException(Object, 'kernel.exception', Object)
call_user_func(Array, Object, 'kernel.exception', Object) (Line: 111)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('kernel.exception', Object) (Line: 228)
Symfony\Component\HttpKernel\HttpKernel->handleException(Object, Object, 1) (Line: 79)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 99)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 78)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 693)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
hunchang’s picture

hunchang commented
StatusFileSize
new rename_admin_paths-RenameProcessor-3040984-3.patch1.33 KB

after checking on RenameAdminPathsProcessor.php, current version (1.1) is returning $path = null which is causing the problem.
Cross checked dev version, it is $path = '/404', suggest to use Drupal's NotFoundHttpException() method.

Attached the patch, please test.

hunchang’s picture

hunchang commented
Version: 8.x-1.1 » 8.x-1.x-dev
Status: Active » Needs review
hunchang’s picture

hunchang commented
Version: 8.x-1.x-dev » 8.x-1.1
StatusFileSize
new rename_admin_paths-RenameProcessor-3040984-5.patch10.67 KB

Sorry, first time contributing.
Changed the patch file to current version 1.1

hunchang’s picture

hunchang commented
StatusFileSize
new rename_admin_paths-RenameProcessor-3040984-6.patch1.28 KB
EurekaWeb’s picture

EurekaWeb commented

Not sure if the issue is related to any recent Core updates but when the above patch is applied the following errors now show when cache is cleared.

Symfony\Component\HttpKernel\Exception\NotFoundHttpException: in Drupal\rename_admin_paths\RenameAdminPathsProcessor->processInbound() (line 43 of /home/mysite/public_html/modules/rename_admin_paths/src/RenameAdminPathsProcessor.php).

guncha25’s picture

guncha25 commented
StatusFileSize
new rename_admin_paths-RenameProcessor-3040984-8.patch1.25 KB
raphael apard’s picture

raphael apard commented
Status: Needs review » Fixed
raphael apard’s picture

raphael apard commented
Status: Fixed » Closed (fixed)